Skip to content

Commit b130bea

Browse files
committed
lint: misc
1 parent 131c223 commit b130bea

19 files changed

+28
-28
lines changed

lib/ads/ad_navigator_observer.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ class AdNavigatorObserver extends NavigatorObserver {
118118
_pageTransitionCount >= requiredTransitions) {
119119
_logger.info('Interstitial ad due. Requesting ad.');
120120
_showInterstitialAd();
121-
_pageTransitionCount = 0; // Reset count after showing
121+
_pageTransitionCount = 0;
122122
}
123123
}
124124

lib/ads/admob_ad_provider.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class AdMobAdProvider implements AdProvider {
2626
final Logger _logger;
2727
final Uuid _uuid = const Uuid();
2828

29-
static const _adLoadTimeout = 15; // Unified timeout for all ad types
29+
static const _adLoadTimeout = 15;
3030

3131
@override
3232
Future<void> initialize() async {

lib/ads/models/banner_ad.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import 'package:core/core.dart'; // Import core for AdPlatformType
1+
import 'package:core/core.dart';
22
import 'package:flutter/foundation.dart';
33
import 'package:flutter_news_app_mobile_client_full_source_code/ads/models/inline_ad.dart';
44

lib/ads/models/inline_ad.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import 'package:core/core.dart'; // Import core for AdPlatformType
1+
import 'package:core/core.dart';
22
import 'package:equatable/equatable.dart';
33
import 'package:flutter/foundation.dart';
44

lib/ads/models/interstitial_ad.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import 'package:core/core.dart'; // Import core for AdPlatformType
1+
import 'package:core/core.dart';
22
import 'package:equatable/equatable.dart';
33
import 'package:flutter/foundation.dart';
44

lib/ads/models/native_ad.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import 'package:core/core.dart'; // Import core for AdPlatformType
1+
import 'package:core/core.dart';
22
import 'package:flutter/foundation.dart';
33
import 'package:flutter_news_app_mobile_client_full_source_code/ads/models/inline_ad.dart';
44

lib/ads/widgets/admob_inline_ad_widget.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class AdmobInlineAdWidget extends StatefulWidget {
3838
}
3939

4040
class _AdmobInlineAdWidgetState extends State<AdmobInlineAdWidget> {
41-
admob.Ad? _ad; // Can be NativeAd or BannerAd
41+
admob.Ad? _ad;
4242
final Logger _logger = Logger('AdmobInlineAdWidget');
4343

4444
@override
@@ -80,7 +80,7 @@ class _AdmobInlineAdWidgetState extends State<AdmobInlineAdWidget> {
8080
} else if (widget.inlineAd.adObject is admob.BannerAd) {
8181
_ad = widget.inlineAd.adObject as admob.BannerAd;
8282
} else {
83-
_ad = null; // Ensure _ad is null if the type is incorrect
83+
_ad = null;
8484

8585
_logger.severe(
8686
'The provided ad object for AdMob inline ad is not of type '
@@ -111,7 +111,7 @@ class _AdmobInlineAdWidgetState extends State<AdmobInlineAdWidget> {
111111
// If largeThumbnail, assume mediumRectangle (300x250), otherwise standard banner (320x50).
112112
adHeight = widget.headlineImageStyle == HeadlineImageStyle.largeThumbnail
113113
? 250 // Height for mediumRectangle
114-
: 50; // Height for standard banner
114+
: 50;
115115
} else {
116116
// Fallback height for unknown inline ad types.
117117
adHeight = 100;

lib/ads/widgets/feed_ad_loader_widget.dart

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class _FeedAdLoaderWidgetState extends State<FeedAdLoaderWidget> {
6262
InlineAd? _loadedAd;
6363
bool _isLoading = true;
6464
bool _hasError = false;
65-
final Logger _logger = Logger('FeedAdLoaderWidget'); // Renamed logger
65+
final Logger _logger = Logger('FeedAdLoaderWidget');
6666
final InlineAdCacheService _adCacheService = InlineAdCacheService();
6767

6868
/// Completer to manage the lifecycle of the ad loading future.
@@ -100,7 +100,7 @@ class _FeedAdLoaderWidgetState extends State<FeedAdLoaderWidget> {
100100
),
101101
);
102102
}
103-
_loadAdCompleter = null; // Clear the old completer for the new load
103+
_loadAdCompleter = null;
104104

105105
// Immediately set the widget to a loading state to prevent UI flicker.
106106
// This ensures a smooth transition from the old ad (or no ad) to the
@@ -110,7 +110,7 @@ class _FeedAdLoaderWidgetState extends State<FeedAdLoaderWidget> {
110110
_isLoading = true;
111111
_hasError = false;
112112
});
113-
_loadAd(); // Start loading the new ad
113+
_loadAd();
114114
}
115115
}
116116

@@ -160,7 +160,7 @@ class _FeedAdLoaderWidgetState extends State<FeedAdLoaderWidget> {
160160
// Complete the completer only if it hasn't been completed already
161161
// (e.g., by dispose() or didUpdateWidget() cancelling an old load).
162162
if (_loadAdCompleter?.isCompleted == false) {
163-
_loadAdCompleter!.complete(); // Complete the completer on success
163+
_loadAdCompleter!.complete();
164164
}
165165
return;
166166
}
@@ -220,7 +220,7 @@ class _FeedAdLoaderWidgetState extends State<FeedAdLoaderWidget> {
220220
});
221221
// Complete the completer only if it hasn't been completed already.
222222
if (_loadAdCompleter?.isCompleted == false) {
223-
_loadAdCompleter!.complete(); // Complete the completer on success
223+
_loadAdCompleter!.complete();
224224
}
225225
} else {
226226
_logger.warning(
@@ -237,7 +237,7 @@ class _FeedAdLoaderWidgetState extends State<FeedAdLoaderWidget> {
237237
if (_loadAdCompleter?.isCompleted == false) {
238238
_loadAdCompleter?.completeError(
239239
StateError('Failed to load ad: No ad returned.'),
240-
); // Complete with error
240+
);
241241
}
242242
}
243243
} catch (e, s) {
@@ -254,7 +254,7 @@ class _FeedAdLoaderWidgetState extends State<FeedAdLoaderWidget> {
254254
});
255255
// Complete the completer with an error only if it hasn't been completed already.
256256
if (_loadAdCompleter?.isCompleted == false) {
257-
_loadAdCompleter?.completeError(e); // Complete with error
257+
_loadAdCompleter?.completeError(e);
258258
}
259259
}
260260
}

lib/bootstrap.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ Future<Widget> bootstrap(
109109
};
110110

111111
final adService = AdService(adProviders: adProviders, logger: logger);
112-
await adService.initialize(); // Initialize all selected AdProviders early
112+
await adService.initialize();
113113

114114
// Fetch the initial user from the authentication repository.
115115
// This ensures the AppBloc starts with an accurate authentication status.

lib/headlines-feed/bloc/countries_filter_bloc.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import 'package:core/core.dart';
66
import 'package:data_repository/data_repository.dart';
77
import 'package:equatable/equatable.dart';
88
import 'package:flutter_news_app_mobile_client_full_source_code/app/bloc/app_bloc.dart';
9-
import 'package:flutter_news_app_mobile_client_full_source_code/headlines-feed/view/country_filter_page.dart'; // Import AppBloc
9+
import 'package:flutter_news_app_mobile_client_full_source_code/headlines-feed/view/country_filter_page.dart';
1010

1111
part 'countries_filter_event.dart';
1212
part 'countries_filter_state.dart';
@@ -38,7 +38,7 @@ class CountriesFilterBloc
3838
on<CountriesFilterApplyFollowedRequested>(
3939
_onCountriesFilterApplyFollowedRequested,
4040
transformer: restartable(),
41-
); // Register new event handler
41+
);
4242
}
4343

4444
final DataRepository<Country> _countriesRepository;

0 commit comments

Comments
 (0)