Skip to content

Commit c3064bd

Browse files
committed
refactor(headlines-feed): remove unnecessary variable and simplify code
- Remove unnecessary 'tile' variable and simplify the switch statement - Directly return the appropriate HeadlineTile widget in each case - Remove redundant IconButton (trailing) which was not in use
1 parent 481a6f4 commit c3064bd

File tree

1 file changed

+3
-20
lines changed

1 file changed

+3
-20
lines changed

lib/headlines-feed/view/headlines_feed_page.dart

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -263,53 +263,36 @@ class _HeadlinesFeedPageState extends State<HeadlinesFeedPage>
263263
.watch<AppBloc>()
264264
.state
265265
.feedItemImageStyle;
266-
Widget tile;
267-
268-
final trailing = IconButton(
269-
icon: const Icon(Icons.more_vert),
270-
onPressed: () {
271-
showModalBottomSheet<void>(
272-
context: context,
273-
builder: (_) => HeadlineActionsBottomSheet(
274-
headline: item,
275-
),
276-
);
277-
},
278-
);
279266

280267
switch (imageStyle) {
281268
case FeedItemImageStyle.hidden:
282-
tile = HeadlineTileTextOnly(
269+
return HeadlineTileTextOnly(
283270
headline: item,
284271
onHeadlineTap: () =>
285272
HeadlineTapHandler.handleHeadlineTap(
286273
context,
287274
item,
288275
),
289-
trailing: trailing,
290276
);
291277
case FeedItemImageStyle.smallThumbnail:
292-
tile = HeadlineTileImageStart(
278+
return HeadlineTileImageStart(
293279
headline: item,
294280
onHeadlineTap: () =>
295281
HeadlineTapHandler.handleHeadlineTap(
296282
context,
297283
item,
298284
),
299-
trailing: trailing,
300285
);
301286
case FeedItemImageStyle.largeThumbnail:
302-
tile = HeadlineTileImageTop(
287+
return HeadlineTileImageTop(
303288
headline: item,
304289
onHeadlineTap: () =>
305290
HeadlineTapHandler.handleHeadlineTap(
306291
context,
307292
item,
308293
),
309-
trailing: trailing,
310294
);
311295
}
312-
return tile;
313296
} else if (item is AdPlaceholder) {
314297
// Access the AppBloc to get the remoteConfig for ads.
315298
final remoteConfig = context

0 commit comments

Comments
 (0)