Skip to content

Commit d5c85cf

Browse files
committed
refactor(headlines-search): improve ad caching and remove unused imports
- Inject InlineAdCacheService into HeadlinesSearchBloc - Replace InlineAdCacheService instantiation with injected service - Remove unused AdService import from headlines_search_page.dart - Update ad loading to use FeedAdLoaderWidget without explicit AdService
1 parent 48b805c commit d5c85cf

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

lib/headlines-search/bloc/headlines_search_bloc.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,14 @@ class HeadlinesSearchBloc
2222
required DataRepository<Country> countryRepository,
2323
required AppBloc appBloc,
2424
required FeedDecoratorService feedDecoratorService,
25+
required InlineAdCacheService inlineAdCacheService,
2526
}) : _headlinesRepository = headlinesRepository,
2627
_topicRepository = topicRepository,
2728
_sourceRepository = sourceRepository,
2829
_countryRepository = countryRepository,
2930
_appBloc = appBloc,
3031
_feedDecoratorService = feedDecoratorService,
32+
_inlineAdCacheService = inlineAdCacheService,
3133
super(const HeadlinesSearchInitial()) {
3234
on<HeadlinesSearchModelTypeChanged>(_onHeadlinesSearchModelTypeChanged);
3335
on<HeadlinesSearchFetchRequested>(
@@ -42,6 +44,7 @@ class HeadlinesSearchBloc
4244
final DataRepository<Country> _countryRepository;
4345
final AppBloc _appBloc;
4446
final FeedDecoratorService _feedDecoratorService;
47+
final InlineAdCacheService _inlineAdCacheService;
4548
static const _limit = 10;
4649

4750
Future<void> _onHeadlinesSearchModelTypeChanged(
@@ -201,7 +204,7 @@ class HeadlinesSearchBloc
201204
}
202205

203206
// New search, clear previous ad cache.
204-
InlineAdCacheService().clearAllAds();
207+
_inlineAdCacheService.clearAllAds();
205208
emit(
206209
HeadlinesSearchLoading(
207210
lastSearchTerm: searchTerm,

lib/headlines-search/view/headlines_search_page.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import 'package:core/core.dart';
66
import 'package:flutter/material.dart';
77
import 'package:flutter_bloc/flutter_bloc.dart';
8-
import 'package:flutter_news_app_mobile_client_full_source_code/ads/ad_service.dart';
98
import 'package:flutter_news_app_mobile_client_full_source_code/ads/interstitial_ad_manager.dart';
109
import 'package:flutter_news_app_mobile_client_full_source_code/ads/models/ad_placeholder.dart';
1110
import 'package:flutter_news_app_mobile_client_full_source_code/ads/models/ad_theme_style.dart';
@@ -365,7 +364,6 @@ class _HeadlinesSearchViewState extends State<_HeadlinesSearchView> {
365364

366365
return FeedAdLoaderWidget(
367366
adPlaceholder: feedItem,
368-
adService: context.read<AdService>(),
369367
adThemeStyle: AdThemeStyle.fromTheme(
370368
Theme.of(context),
371369
),

0 commit comments

Comments
 (0)