Various fixes thanks to Scrutinizer

Author: willdurand

src/Geocoder/Adapter/GeoIP2Adapter.php

@@ -10,9 +10,9 @@
 
 namespace Geocoder\Adapter;
 
+use GeoIp2\ProviderInterface;
 use Geocoder\Exception\InvalidArgument;
 use Geocoder\Exception\UnsupportedOperation;
-use GeoIp2\ProviderInterface;
 
 /**
  * @author Jens Wiese <jens@howtrueisfalse.de>

src/Geocoder/Model/Address.php

@@ -70,6 +70,13 @@ final class Address
      */
     private $timezone;
 
+    /**
+     * @param string $streetNumber
+     * @param string $streetName
+     * @param string $postalCode
+     * @param string $locality
+     * @param string $subLocality
+     */
     public function __construct(
         Coordinates $coordinates = null,
         Bounds $bounds           = null,

src/Geocoder/Model/AddressFactory.php

@@ -75,6 +75,9 @@ private function readStringValue(array $data, $key)
         return $this->valueOrNull(\igorw\get_in($data, [ $key ]));
     }
 
+    /**
+     * @return string
+     */
     private function valueOrNull($str)
     {
         return empty($str) ? null : $str;
@@ -98,6 +101,10 @@ private function upperize($str)
         return null;
     }
 
+    /**
+     * @param double $latitude
+     * @param double $longitude
+     */
     private function createCoordinates($latitude, $longitude)
     {
         if (null === $latitude || null === $longitude) {

src/Geocoder/Model/Country.php

@@ -58,7 +58,7 @@ public function getCode()
     /**
      * Returns a string with the country name.
      *
-     * @return array
+     * @return string
      */
     public function toString()
     {

src/Geocoder/Model/County.php

@@ -58,7 +58,7 @@ public function getCode()
     /**
      * Returns a string with the county name.
      *
-     * @return array
+     * @return string
      */
     public function toString()
     {

src/Geocoder/Model/Region.php

@@ -58,7 +58,7 @@ public function getCode()
     /**
      * Returns a string with the region name.
      *
-     * @return array
+     * @return string
      */
     public function toString()
     {

src/Geocoder/Provider/ArcGISOnline.php

@@ -155,6 +155,9 @@ private function buildQuery($query)
         return sprintf('%s&maxLocations=%d&f=%s&outFields=*', $query, $this->getLimit(), 'json');
     }
 
+    /**
+     * @param string $query
+     */
     private function executeQuery($query)
     {
         $query   = $this->buildQuery($query);

src/Geocoder/Provider/BingMaps.php

@@ -112,6 +112,9 @@ public function setLocale($locale)
         return $this;
     }
 
+    /**
+     * @param string $query
+     */
     private function executeQuery($query)
     {
         if (null !== $this->getLocale()) {

src/Geocoder/Provider/Chain.php

@@ -10,8 +10,8 @@
 
 namespace Geocoder\Provider;
 
-use Geocoder\Exception\InvalidCredentials;
 use Geocoder\Exception\ChainNoResult;
+use Geocoder\Exception\InvalidCredentials;
 
 /**
  * @author Markus Bachmann <markus.bachmann@bachi.biz>

src/Geocoder/Provider/FreeGeoIp.php

@@ -57,6 +57,9 @@ public function getName()
         return 'free_geo_ip';
     }
 
+    /**
+     * @param string $query
+     */
     private function executeQuery($query)
     {
         $content = (string) $this->getAdapter()->get($query)->getBody();