Skip to content

Commit 70435c7

Browse files
committed
fix(test-utils): Move @spotlightjs/spotlight to repo root devDependencies
Installing Spotlight in individual test apps causes version conflicts because Spotlight's transitive dependencies (e.g. @sentry/electron) require specific @sentry/* versions that conflict with the freshly built packages used by E2E tests. Moving to root devDependencies avoids this conflict - the Spotlight CLI is available globally without polluting test app dependency trees.
1 parent 130bd92 commit 70435c7

File tree

3 files changed

+1
-2
lines changed

3 files changed

+1
-2
lines changed

dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
"devDependencies": {
4545
"@playwright/test": "~1.56.0",
4646
"@sentry-internal/test-utils": "link:../../../test-utils",
47-
"@spotlightjs/spotlight": "^4.7.2",
4847
"serve": "14.0.1",
4948
"npm-run-all2": "^6.2.0"
5049
},

dev-packages/test-utils/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
"devDependencies": {
5050
"@playwright/test": "~1.56.0",
5151
"@sentry/core": "10.30.0",
52-
"@spotlightjs/spotlight": "^4.7.2",
5352
"eslint-plugin-regexp": "^1.15.0"
5453
},
5554
"volta": {

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@
104104
"dev-packages/bundler-tests"
105105
],
106106
"devDependencies": {
107+
"@spotlightjs/spotlight": "^4.7.2",
107108
"@rollup/plugin-commonjs": "^25.0.7",
108109
"@rollup/plugin-esm-shim": "^0.1.5",
109110
"@rollup/plugin-json": "^6.1.0",

0 commit comments

Comments
 (0)