fix tests, adjust jsdoc

Author: Lms24

dev-packages/browser-integration-tests/suites/public-api/logger/integration/test.ts

@@ -167,7 +167,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
             'sentry.message.template': { value: 'Mixed: {} {} {} {}', type: 'string' },
             'sentry.message.parameter.0': { value: 'prefix', type: 'string' },
             'sentry.message.parameter.1': { value: '{"obj":true}', type: 'string' },
-            'sentry.message.parameter.2': { value: [4, 5, 6], type: 'integer[]' },
+            'sentry.message.parameter.2': { value: '[4,5,6]', type: 'string' },
             'sentry.message.parameter.3': { value: 'suffix', type: 'string' },
           },
         },
@@ -236,7 +236,7 @@ sentryTest('should capture console object calls', async ({ getLocalTestUrl, page
             'sentry.message.template': { value: 'hello {} {} {}', type: 'string' },
             'sentry.message.parameter.0': { value: true, type: 'boolean' },
             'sentry.message.parameter.1': { value: 'null', type: 'string' },
-            'sentry.message.parameter.2': { value: 'undefined', type: 'string' },
+            'sentry.message.parameter.2': { value: '', type: 'string' },
           },
         },
       ],

dev-packages/browser-integration-tests/suites/public-api/logger/scopeAttributes/subject.js

@@ -3,6 +3,9 @@ Sentry.logger.info('log_before_any_scope', { log_attr: 'log_attr_1' });
 
 Sentry.getGlobalScope().setAttributes({ global_scope_attr: true });
 
+// this attribute will not be sent for now
+Sentry.getGlobalScope().setAttribute('array_attr', [1, 2, 3]);
+
 // global scope, log attribute
 Sentry.logger.info('log_after_global_scope', { log_attr: 'log_attr_2' });
 

dev-packages/node-integration-tests/suites/public-api/logger/scenario.ts

@@ -15,6 +15,9 @@ async function run(): Promise<void> {
 
   Sentry.getGlobalScope().setAttribute('global_scope_attr', true);
 
+  // this attribute will not be sent for now
+  Sentry.getGlobalScope().setAttributes({ array_attr: [1, 2, 3] });
+
   // global scope, log attribute
   Sentry.logger.info('log_after_global_scope', { log_attr: 'log_attr_2' });
 

dev-packages/node-integration-tests/suites/public-api/logger/test.ts

@@ -25,12 +25,12 @@ const commonAttributes: SerializedLog['attributes'] = {
   },
 };
 
-describe('metrics', () => {
+describe('logs', () => {
   afterAll(() => {
     cleanupChildProcesses();
   });
 
-  test('should capture all metric types', async () => {
+  test('captures logs with scope and log attributes', async () => {
     const runner = createRunner(__dirname, 'scenario.ts')
       .expect({
         log: {

packages/core/src/attributes.ts

@@ -62,11 +62,13 @@ export function isAttributeObject(maybeObj: unknown): maybeObj is AttributeObjec
 }
 
 export function attributeValueToTypedAttributeValue(rawValue: unknown, useFallback?: true): TypedAttributeValue;
+
 /**
  * Converts an attribute value to a typed attribute value.
  *
- * Does not allow mixed arrays. In case of a mixed array, the value is stringified and the type is 'string'.
- * All values besides the supported attribute types (see {@link AttributeTypeMap}) are stringified to a string attribute value.
+ * For now, we intentionally only support primitive values and attribute objects with primitive values.
+ * If @param useFallback is true, we stringify non-primitive values to a string attribute value. Otherwise
+ * we return `undefined` for unsupported values.
  *
  * @param value - The value of the passed attribute.
  * @param useFallback - If true, unsupported values will be stringified to a string attribute value.