Skip to content

Commit e540350

Browse files
committed
more tests
1 parent cea78ba commit e540350

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

packages/core/src/scope.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ export class Scope {
336336
* Sets an attribute onto the scope.
337337
*
338338
* These attributes are currently only applied to logs.
339-
* In the future, they will be applied to metrics and spans.
339+
* In the future, they will also be applied to metrics and spans.
340340
*
341341
* Important: For now, only strings, numbers and boolean attributes are supported, despite types allowing for
342342
* more complex attribute types. We'll add this support in the future but already specify the wider type to

packages/core/test/lib/attributes.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ describe('attributeValueToTypedAttributeValue', () => {
1212
});
1313
});
1414

15-
it('converts an integer number value to a typed attribute value', () => {
16-
const result = attributeValueToTypedAttributeValue(42);
15+
it.each([42, 42.0])('converts an integer number value to a typed attribute value (%s)', value => {
16+
const result = attributeValueToTypedAttributeValue(value);
1717
expect(result).toStrictEqual({
18-
value: 42,
18+
value: value,
1919
type: 'integer',
2020
});
2121
});

0 commit comments

Comments
 (0)