Move isSigned/isUnsigned to BuiltInTypes

Author: lcartey

cpp/misra/src/codingstandards/cpp/misra/BuiltInTypeRules.qll

@@ -137,6 +137,10 @@ class NumericType extends Type {
   Type getRealType() { result = realType }
 }
 
+predicate isSignedType(NumericType t) { t.getSignedness() = Signed() }
+
+predicate isUnsignedType(NumericType t) { t.getSignedness() = Unsigned() }
+
 /**
  * One of the 10 canonical integer types, which are the standard integer types.
  */

cpp/misra/src/rules/RULE-7-0-4/InappropriateBitwiseOrShiftOperands.ql

@@ -16,10 +16,6 @@ import cpp
 import codingstandards.cpp.misra
 import codingstandards.cpp.misra.BuiltInTypeRules
 
-predicate isSignedType(NumericType t) { t.getSignedness() = Signed() }
-
-predicate isUnsignedType(NumericType t) { t.getSignedness() = Unsigned() }
-
 predicate isConstantExpression(Expr e) {
   e instanceof Literal or
   e.isConstant()