Exclude literals used in class template instantiation

Author: rvermeulen

cpp/autosar/src/rules/A5-1-1/LiteralValueUsedOutsideTypeInit.ql

@@ -52,7 +52,10 @@ where
   not l = any(ArrayOrVectorAggregateLiteral aal).getAnElementExpr(_).getAChild*() and
   // Ignore x - 1 expressions
   not exists(SubExpr se | se.getRightOperand() = l and l.getValue() = "1") and
-  not l instanceof CompileTimeComputedIntegralLiteral 
+  not l instanceof CompileTimeComputedIntegralLiteral and
+  // Exclude literals to instantiate a class template per example in the standard
+  // where an type of std::array is intialized with size 5.
+  not l = any(ClassTemplateInstantiation cti).getATemplateArgument()
 select l,
   "Literal value " + getTruncatedLiteralText(l) + " used outside of type initialization " +
     l.getAPrimaryQlClass()

cpp/autosar/test/rules/A5-1-1/LiteralValueUsedOutsideTypeInit.expected

@@ -6,4 +6,3 @@
 | test.cpp:104:8:104:8 | 4 | Literal value 4 used outside of type initialization Literal |
 | test.cpp:104:8:104:8 | 4 | Literal value 4 used outside of type initialization Literal |
 | test.cpp:104:8:104:8 | 4 | Literal value 4 used outside of type initialization Literal |
-| test.cpp:108:18:108:18 | 1 | Literal value 1 used outside of type initialization Literal |

cpp/autosar/test/rules/A5-1-1/test.cpp

@@ -105,7 +105,7 @@ template <typename T, int size> struct S2 {
 };
 
 void test_fp_reported_in_371() {
-  struct S2<int, 1> l1;    // COMPLIANT[FALSE_POSITIVE]
+  struct S2<int, 1> l1;    // COMPLIANT
   struct S2<int, g1> l2;   // COMPLIANT
   struct S2<int, f1()> l3; // COMPLIANT
 }