Added RULE-14-3

Author: s-samadi

c/misra/src/rules/RULE-14-3/ControllingExpInvariantCondition.ql

@@ -0,0 +1,54 @@
+/**
+ * @id c/misra/controlling-exp-invariant-condition
+ * @name RULE-14-3: Controlling expressions shall not be invariant
+ * @description If a controlling expression has an invariant value then it is possible that there is
+ *              a programming error.
+ * @kind problem
+ * @precision very-high
+ * @problem.severity error
+ * @tags external/misra/id/rule-14-3
+ *       correctness
+ *       maintainability
+ *       readability
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.c.misra
+
+from ControlFlowNode expr, string message
+where
+  not isExcluded(expr, Statements5Package::controllingExpInvariantConditionQuery()) and
+  (
+    exists(IfStmt ifStmt |
+      (
+        ifStmt.getControllingExpr() = expr and
+        (
+          conditionAlwaysFalse(expr)
+          or
+          conditionAlwaysTrue(expr)
+        )
+      )
+    ) and
+    message = "Controlling expression in if statement has invariant value."
+  )
+  or
+  exists(Loop loop |
+    loop.getControllingExpr() = expr and
+    (
+      conditionAlwaysFalse(expr)
+      or
+      conditionAlwaysTrue(expr)
+    )
+  ) and
+  message = "Controlling expression in loop statement has invariant value."
+  or
+  exists(SwitchStmt switch |
+    switch.getControllingExpr() = expr and
+    (
+      conditionAlwaysFalse(expr) and
+      conditionAlwaysTrue(expr)
+    )
+  ) and
+  message = "Controlling expression in switch statement has invariant value."
+select expr, message

c/misra/test/rules/RULE-14-3/ControllingExpInvariantCondition.expected

@@ -0,0 +1,3 @@
+| test.c:2:7:2:11 | ... > ... | Controlling expression in if statement has invariant value. |
+| test.c:13:10:13:16 | ... > ... | Controlling expression in loop statement has invariant value. |
+| test.c:14:9:14:13 | ... > ... | Controlling expression in if statement has invariant value. |

c/misra/test/rules/RULE-14-3/ControllingExpInvariantCondition.qlref

@@ -0,0 +1 @@
+rules/RULE-14-3/ControllingExpInvariantCondition.ql

c/misra/test/rules/RULE-14-3/test.c

@@ -0,0 +1,17 @@
+void f1(int p1) {
+  if (2 > 3) { // NON_COMPLIANT
+  }
+
+  if (p1 > 0) { // COMPLIANT
+  }
+
+  if (p1 < 10 && p1 > 20) { // NON_COMPLIANT[FALSE_NEGATIVE]
+  }
+}
+
+void f2(int p1) {
+  while (20 > 10) { // NON_COMPLIANT
+    if (1 > 2) {
+    } // NON_COMPLIANT
+  }
+}