Add reason to alert message

Author: rvermeulen

c/misra/src/rules/RULE-14-2/ForLoopNotWellFormed.ql

@@ -15,8 +15,8 @@ import cpp
 import codingstandards.c.misra
 import codingstandards.cpp.Loops
 
-from ForStmt for
+from ForStmt for, Element reasonLocation, string reason, string reasonLabel
 where
   not isExcluded(for, Statements4Package::forLoopNotWellFormedQuery()) and
-  isInvalidLoop(for)
-select for, "For loop is not well formed."
+  isInvalidLoop(for, reason, reasonLocation, reasonLabel)
+select for, "For loop is not well formed, " + reason + ".", reasonLocation, reasonLabel

c/misra/test/rules/RULE-14-2/ForLoopNotWellFormed.expected

@@ -1,7 +1,7 @@
-| test.c:7:3:8:3 | for(...;...;...) ... | For loop is not well formed. |
-| test.c:14:3:15:3 | for(...;...;...) ... | For loop is not well formed. |
-| test.c:20:3:21:3 | for(...;...;...) ... | For loop is not well formed. |
-| test.c:25:3:26:3 | for(...;...;...) ... | For loop is not well formed. |
-| test.c:38:3:39:3 | for(...;...;...) ... | For loop is not well formed. |
-| test.c:52:3:53:3 | for(...;...;...) ... | For loop is not well formed. |
-| test.c:64:3:67:3 | for(...;...;...) ... | For loop is not well formed. |
+| test.c:7:3:8:3 | for(...;...;...) ... | For loop is not well formed, it uses a loop counter '$@' of type floating-point. | test.c:7:14:7:14 | f | f |
+| test.c:14:3:15:3 | for(...;...;...) ... | For loop is not well formed, it uses multiple loop counters$@. | file://:0:0:0:0 |  |  |
+| test.c:20:3:21:3 | for(...;...;...) ... | For loop is not well formed, it uses multiple loop counters$@. | file://:0:0:0:0 |  |  |
+| test.c:25:3:26:3 | for(...;...;...) ... | For loop is not well formed, it $@ its loop counter 'i' with an operation that is not an increment or decrement. | test.c:25:28:25:28 | i | updates |
+| test.c:38:3:39:3 | for(...;...;...) ... | For loop is not well formed, it $@ the loop counter 'x' irregularly. | test.c:38:26:38:26 | x | updates |
+| test.c:52:3:53:3 | for(...;...;...) ... | For loop is not well formed, it updates $@, a loop control variable other than the loop counter, in the update expression of the loop. | test.c:52:28:52:29 | p1 | p1 |
+| test.c:64:3:67:3 | for(...;...;...) ... | For loop is not well formed, it $@ the loop counter 'x' in the body of the loop. | test.c:65:5:65:5 | x | updates |