Apply suggestions from code review

atorralba · smowton · web-flow · commit 136fefbab55f · 2022-01-14T13:38:17.000+01:00
Co-authored-by: Chris Smowton &lt;smowton@github.com&gt;
diff --git a/java/ql/src/experimental/Security/CWE/CWE-552/UnsafeUrlForward.qll b/java/ql/src/experimental/Security/CWE/CWE-552/UnsafeUrlForward.qll
@@ -122,7 +122,7 @@ private predicate isDisallowListCheck(MethodAccess ma) {
  */
 private class PathMatchGuard extends UnsafeUrlForwardBarrierGuard {
   PathMatchGuard() {
-    isExactStringPathMatch(this) or isStringPathMatch(this) or isFilePathMatch(this)
+    isExactStringPathMatch(this) or isAllowListCheck(this) or isDisallowListCheck(this)
   }
 
   override predicate checks(Expr e, boolean branch) {

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ private predicate isDisallowListCheck(MethodAccess ma) {`
`122`	`122`	`*/`
`123`	`123`	`private class PathMatchGuard extends UnsafeUrlForwardBarrierGuard {`
`124`	`124`	`PathMatchGuard() {`
`125`		`- isExactStringPathMatch(this) or isStringPathMatch(this) or isFilePathMatch(this)`
	`125`	`+ isExactStringPathMatch(this) or isAllowListCheck(this) or isDisallowListCheck(this)`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`override predicate checks(Expr e, boolean branch) {`