Merge pull request #7378 from hvitved/ruby/module-infinite-loop

Ruby: Prevent infinite recursion in module resolution library

Author: hvitved

ruby/ql/lib/codeql/ruby/ApiGraphs.qll

@@ -244,7 +244,7 @@ module API {
       MkUse(DataFlow::Node nd) { isUse(nd) }
 
     private string resolveTopLevel(ConstantReadAccess read) {
-      TResolved(result) = resolveScopeExpr(read) and
+      TResolved(result) = resolveConstantReadAccess(read) and
       not result.matches("%::%")
     }
 

ruby/ql/lib/codeql/ruby/ast/Constant.qll

@@ -136,7 +136,7 @@ class ConstantReadAccess extends ConstantAccess {
     this.hasGlobalScope() and
     result = lookupConst(TResolved("Object"), this.getName())
     or
-    result = lookupConst(resolveScopeExpr(this.getScopeExpr()), this.getName())
+    result = lookupConst(resolveConstantReadAccess(this.getScopeExpr()), this.getName())
   }
 
   override string getValueText() { result = this.getValue().getValueText() }