Update cpp/ql/lib/semmle/code/cpp/models/interfaces/FormattingFunction.qll

calumgrant · geoffw0 · calumgrant · commit 4a14a3cacb51 · 2024-09-26T09:31:40.000+01:00
Co-authored-by: Geoffrey White &lt;40627776+geoffw0@users.noreply.github.com&gt;
diff --git a/cpp/ql/lib/semmle/code/cpp/models/interfaces/FormattingFunction.qll b/cpp/ql/lib/semmle/code/cpp/models/interfaces/FormattingFunction.qll
@@ -143,8 +143,7 @@ abstract class FormattingFunction extends ArrayFunction, TaintFunction {
    * of parameters, then don't return anything.
    */
   int getNumberOfExplicitParameters() {
-    result = this.getAnExplicitDeclarationEntry().getNumberOfParameters() and
-    forall(FunctionDeclarationEntry fde | fde = this.getAnExplicitDeclarationEntry() |
+    forex(FunctionDeclarationEntry fde | fde = this.getAnExplicitDeclarationEntry() |
       result = fde.getNumberOfParameters()
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -143,8 +143,7 @@ abstract class FormattingFunction extends ArrayFunction, TaintFunction {`
`143`	`143`	`* of parameters, then don't return anything.`
`144`	`144`	`*/`
`145`	`145`	`int getNumberOfExplicitParameters() {`
`146`		`- result = this.getAnExplicitDeclarationEntry().getNumberOfParameters() and`
`147`		`- forall(FunctionDeclarationEntry fde \| fde = this.getAnExplicitDeclarationEntry() \|`
	`146`	`+ forex(FunctionDeclarationEntry fde \| fde = this.getAnExplicitDeclarationEntry() \|`
`148`	`147`	`result = fde.getNumberOfParameters()`
`149`	`148`	`)`
`150`	`149`	`}`