remove redundant not-equals check

erik-krogh · erik-krogh · commit 595875ff9862 · 2022-07-13T12:06:12.000+02:00
diff --git a/java/ql/lib/semmle/code/java/security/OverlyLargeRangeQuery.qll b/java/ql/lib/semmle/code/java/security/OverlyLargeRangeQuery.qll
@@ -244,7 +244,6 @@ RegExpCharacterRange getABadRange(string reason, int priority) {
   priority = 1 and
   exists(RegExpCharacterRange other |
     reason = "overlaps with " + other + " in the same character class" and
-    result != other and
     rankRange(result) < rankRange(other) and
     overlap(result, other)
   )
diff --git a/javascript/ql/lib/semmle/javascript/security/OverlyLargeRangeQuery.qll b/javascript/ql/lib/semmle/javascript/security/OverlyLargeRangeQuery.qll
@@ -244,7 +244,6 @@ RegExpCharacterRange getABadRange(string reason, int priority) {
   priority = 1 and
   exists(RegExpCharacterRange other |
     reason = "overlaps with " + other + " in the same character class" and
-    result != other and
     rankRange(result) < rankRange(other) and
     overlap(result, other)
   )
diff --git a/python/ql/lib/semmle/python/security/OverlyLargeRangeQuery.qll b/python/ql/lib/semmle/python/security/OverlyLargeRangeQuery.qll
@@ -244,7 +244,6 @@ RegExpCharacterRange getABadRange(string reason, int priority) {
   priority = 1 and
   exists(RegExpCharacterRange other |
     reason = "overlaps with " + other + " in the same character class" and
-    result != other and
     rankRange(result) < rankRange(other) and
     overlap(result, other)
   )
diff --git a/ruby/ql/lib/codeql/ruby/security/OverlyLargeRangeQuery.qll b/ruby/ql/lib/codeql/ruby/security/OverlyLargeRangeQuery.qll
@@ -244,7 +244,6 @@ RegExpCharacterRange getABadRange(string reason, int priority) {
   priority = 1 and
   exists(RegExpCharacterRange other |
     reason = "overlaps with " + other + " in the same character class" and
-    result != other and
     rankRange(result) < rankRange(other) and
     overlap(result, other)
   )

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,6 @@ RegExpCharacterRange getABadRange(string reason, int priority) {`
`244`	`244`	`priority = 1 and`
`245`	`245`	`exists(RegExpCharacterRange other \|`
`246`	`246`	`reason = "overlaps with " + other + " in the same character class" and`
`247`		`- result != other and`
`248`	`247`	`rankRange(result) < rankRange(other) and`
`249`	`248`	`overlap(result, other)`
`250`	`249`	`)`