Tag more quality queries.

joefarebrother · joefarebrother · commit 5c4548df45e1 · 2025-06-19T14:06:57.000+01:00
Excluded for now for uncertainty: incomplete ordering, import deprecated module
diff --git a/python/ql/src/Classes/ConflictingAttributesInBaseClasses.ql b/python/ql/src/Classes/ConflictingAttributesInBaseClasses.ql
@@ -2,9 +2,9 @@
  * @name Conflicting attributes in base classes
  * @description When a class subclasses multiple base classes and more than one base class defines the same attribute, attribute overriding may result in unexpected behavior by instances of this class.
  * @kind problem
- * @tags reliability
- *       maintainability
- *       modularity
+ * @tags quality
+ *       reliability
+ *       correctness
  * @problem.severity warning
  * @sub-severity low
  * @precision high
diff --git a/python/ql/src/Classes/EqualsOrHash.ql b/python/ql/src/Classes/EqualsOrHash.ql
@@ -2,7 +2,8 @@
  * @name Inconsistent equality and hashing
  * @description Defining equality for a class without also defining hashability (or vice-versa) violates the object model.
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-581
  * @problem.severity warning
diff --git a/python/ql/src/Classes/MissingCallToDel.ql b/python/ql/src/Classes/MissingCallToDel.ql
@@ -2,8 +2,10 @@
  * @name Missing call to `__del__` during object destruction
  * @description An omitted call to a super-class `__del__` method may lead to class instances not being cleaned up properly.
  * @kind problem
- * @tags efficiency
+ * @tags quality
+ *       reliability
  *       correctness
+ *       performance
  * @problem.severity error
  * @sub-severity low
  * @precision high
diff --git a/python/ql/src/Classes/MissingCallToInit.ql b/python/ql/src/Classes/MissingCallToInit.ql
@@ -2,7 +2,8 @@
  * @name Missing call to `__init__` during object initialization
  * @description An omitted call to a super-class `__init__` method may lead to objects of this class not being fully initialized.
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @problem.severity error
  * @sub-severity low
diff --git a/python/ql/src/Classes/MutatingDescriptor.ql b/python/ql/src/Classes/MutatingDescriptor.ql
@@ -2,7 +2,8 @@
  * @name Mutation of descriptor in `__get__` or `__set__` method.
  * @description Descriptor objects can be shared across many instances. Mutating them can cause strange side effects or race conditions.
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @problem.severity error
  * @sub-severity low
diff --git a/python/ql/src/Classes/SubclassShadowing.ql b/python/ql/src/Classes/SubclassShadowing.ql
@@ -4,7 +4,8 @@
  *              method, hides the method in the subclass.
  * @kind problem
  * @problem.severity error
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  * @sub-severity low
  * @precision high
diff --git a/python/ql/src/Classes/SuperclassDelCalledMultipleTimes.ql b/python/ql/src/Classes/SuperclassDelCalledMultipleTimes.ql
@@ -2,7 +2,8 @@
  * @name Multiple calls to `__del__` during object destruction
  * @description A duplicated call to a super-class `__del__` method may lead to class instances not be cleaned up properly.
  * @kind problem
- * @tags efficiency
+ * @tags quality
+ *       reliability
  *       correctness
  * @problem.severity warning
  * @sub-severity high
diff --git a/python/ql/src/Classes/SuperclassInitCalledMultipleTimes.ql b/python/ql/src/Classes/SuperclassInitCalledMultipleTimes.ql
@@ -2,7 +2,8 @@
  * @name Multiple calls to `__init__` during object initialization
  * @description A duplicated call to a super-class `__init__` method may lead to objects of this class not being properly initialized.
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @problem.severity warning
  * @sub-severity high
diff --git a/python/ql/src/Exceptions/IncorrectExceptOrder.ql b/python/ql/src/Exceptions/IncorrectExceptOrder.ql
@@ -3,8 +3,9 @@
  * @description Handling general exceptions before specific exceptions means that the specific
  *              handlers are never executed.
  * @kind problem
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       error-handling
  *       external/cwe/cwe-561
  * @problem.severity error
  * @sub-severity low
diff --git a/python/ql/src/Exceptions/NotImplementedIsNotAnException.ql b/python/ql/src/Exceptions/NotImplementedIsNotAnException.ql
@@ -6,8 +6,9 @@
  * @sub-severity high
  * @precision very-high
  * @id py/raise-not-implemented
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       error-handling
  */
 
 import python
diff --git a/python/ql/src/Expressions/DuplicateKeyInDictionaryLiteral.ql b/python/ql/src/Expressions/DuplicateKeyInDictionaryLiteral.ql
@@ -2,7 +2,8 @@
  * @name Duplicate key in dict literal
  * @description Duplicate key in dict literal. All but the last will be lost.
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       maintainability
  *       useless-code
  *       external/cwe/cwe-561
  * @problem.severity warning
diff --git a/python/ql/src/Expressions/UnintentionalImplicitStringConcatenation.ql b/python/ql/src/Expressions/UnintentionalImplicitStringConcatenation.ql
@@ -2,9 +2,9 @@
  * @name Implicit string concatenation in a list
  * @description Omitting a comma between strings causes implicit concatenation which is confusing in a list.
  * @kind problem
- * @tags reliability
+ * @tags quality
  *       maintainability
- *       convention
+ *       readability
  *       external/cwe/cwe-665
  * @problem.severity warning
  * @sub-severity high
diff --git a/python/ql/src/Expressions/UnsupportedFormatCharacter.ql b/python/ql/src/Expressions/UnsupportedFormatCharacter.ql
@@ -2,7 +2,8 @@
  * @name Unsupported format character
  * @description An unsupported format character in a format string
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @problem.severity error
  * @sub-severity low
diff --git a/python/ql/src/Functions/IncorrectRaiseInSpecialMethod.ql b/python/ql/src/Functions/IncorrectRaiseInSpecialMethod.ql
@@ -2,9 +2,9 @@
  * @name Non-standard exception raised in special method
  * @description Raising a non-standard exception in a special method alters the expected interface of that method.
  * @kind problem
- * @tags reliability
- *       maintainability
- *       convention
+ * @tags quality
+ *       reliability
+ *       error-handling
  * @problem.severity recommendation
  * @sub-severity high
  * @precision very-high
diff --git a/python/ql/src/Functions/IncorrectlyOverriddenMethod.ql b/python/ql/src/Functions/IncorrectlyOverriddenMethod.ql
@@ -2,7 +2,9 @@
  * @name Mismatch between signature and use of an overriding method
  * @description Method has a different signature from the overridden method and, if it were called, would be likely to cause an error.
  * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  * @problem.severity error
  * @sub-severity low
  * @precision high
diff --git a/python/ql/src/Functions/IncorrectlySpecifiedOverriddenMethod.ql b/python/ql/src/Functions/IncorrectlySpecifiedOverriddenMethod.ql
@@ -3,7 +3,9 @@
  * @description Method has a signature that differs from both the signature of its overriding methods and
  *              the arguments with which it is called, and if it were called, would be likely to cause an error.
  * @kind problem
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  * @problem.severity recommendation
  * @sub-severity high
  * @precision high
diff --git a/python/ql/src/Functions/OverlyComplexDelMethod.ql b/python/ql/src/Functions/OverlyComplexDelMethod.ql
@@ -2,11 +2,9 @@
  * @name Overly complex `__del__` method
  * @description `__del__` methods may be called at arbitrary times, perhaps never called at all, and should be simple.
  * @kind problem
- * @tags efficiency
+ * @tags quality
  *       maintainability
  *       complexity
- *       statistical
- *       non-attributable
  * @problem.severity recommendation
  * @sub-severity low
  * @precision high
diff --git a/python/ql/src/Functions/SignatureOverriddenMethod.ql b/python/ql/src/Functions/SignatureOverriddenMethod.ql
@@ -4,7 +4,8 @@
  *              number and type of parameters has the potential to cause an error when there is a mismatch.
  * @kind problem
  * @problem.severity warning
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @sub-severity high
  * @precision very-high
diff --git a/python/ql/src/Statements/ModificationOfLocals.ql b/python/ql/src/Statements/ModificationOfLocals.ql
@@ -2,7 +2,8 @@
  * @name Modification of dictionary returned by locals()
  * @description Modifications of the dictionary returned by locals() are not propagated to the local variables of a function.
  * @kind problem
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @problem.severity warning
  * @sub-severity low
diff --git a/python/ql/src/Statements/SideEffectInAssert.ql b/python/ql/src/Statements/SideEffectInAssert.ql
@@ -3,8 +3,9 @@
  * @description Side-effects in assert statements result in differences between normal
  *              and optimized behavior.
  * @kind problem
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  * @problem.severity error
  * @sub-severity low
  * @precision high
diff --git a/python/ql/src/Statements/TopLevelPrint.ql b/python/ql/src/Statements/TopLevelPrint.ql
@@ -2,9 +2,9 @@
  * @name Use of a print statement at module level
  * @description Using a print statement at module scope (except when guarded by `if __name__ == '__main__'`) will cause surprising output when the module is imported.
  * @kind problem
- * @tags reliability
+ * @tags quality
  *       maintainability
- *       convention
+ *       readability
  * @problem.severity recommendation
  * @sub-severity high
  * @precision high
