Skip to content

Commit 8892097

Browse files
tausbnasgerf
authored andcommitted
JS: Overlay annotations for some failing tests
Locally these seem to get rid of the compilation warnings, but of course CI is the true arbiter here.
1 parent c09563f commit 8892097

File tree

9 files changed

+10
-0
lines changed

9 files changed

+10
-0
lines changed

javascript/ql/lib/utils/test/InlineSummaries.qll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import javascript
22
import semmle.javascript.dataflow.FlowSummary
33

4+
overlay[local]
45
class MkSummary extends SummarizedCallable {
56
private CallExpr mkSummary;
67

javascript/ql/test/library-tests/AMD/tests.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import javascript
22

3+
overlay[local]
34
class TestAmdModuleRange extends AmdModuleDefinition::Range {
45
TestAmdModuleRange() { this.getCallee().(PropAccess).getQualifiedName() = "test.amd.range" }
56
}

javascript/ql/test/library-tests/CustomAbstractValueDefinitions/CustomAbstractValueDefinitions.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import semmle.javascript.dataflow.internal.FlowSteps as FlowSteps
44
import semmle.javascript.dataflow.internal.AbstractPropertiesImpl as AbstractPropertiesImpl
55
import semmle.javascript.dataflow.CustomAbstractValueDefinitions
66

7+
overlay[local]
78
class MyCustomAbstractValueDefinition extends CustomAbstractValueDefinition {
89
DataFlow::ValueNode node;
910

javascript/ql/test/library-tests/CustomAbstractValueDefinitions/CustomAbstractValueDefinitionsFlow.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import javascript
22
import semmle.javascript.dataflow.InferredTypes
33
import semmle.javascript.dataflow.CustomAbstractValueDefinitions
44

5+
overlay[local]
56
class MyCustomAbstractValueDefinition extends CustomAbstractValueDefinition, AST::ValueNode {
67
MyCustomAbstractValueDefinition() {
78
this.flow() instanceof DataFlow::ObjectLiteralNode and

javascript/ql/test/library-tests/FlowCustomisation/customValues.ql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ private import semmle.javascript.dataflow.InferredTypes
44
/**
55
* A custom abstract value representing the DOM object `document`.
66
*/
7+
overlay[local]
78
class Document extends CustomAbstractValueTag {
89
Document() { this = "document" }
910

@@ -25,6 +26,7 @@ class Document extends CustomAbstractValueTag {
2526
* Note that `getType()` isn't quite right, since `typeof document.all === 'undefined'`,
2627
* but that's fine for the purposes of this test.
2728
*/
29+
overlay[local]
2830
class DocumentAll extends CustomAbstractValueTag {
2931
DocumentAll() { this = "document.all" }
3032

javascript/ql/test/library-tests/ModuleImportNodes/CustomImport.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import javascript
22

3+
overlay[local]
34
class CustomImport extends DataFlow::ModuleImportNode::Range, DataFlow::CallNode {
45
CustomImport() { this.getCalleeName() = "customImport" }
56

javascript/ql/test/library-tests/RecursionPrevention/SourceNodeFlowsTo.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import javascript
99

10+
overlay[local]
1011
class BadSourceNode extends DataFlow::SourceNode {
1112
BadSourceNode() { this.(DataFlow::PropRead).getPropertyName() = "foo" }
1213

javascript/ql/test/library-tests/frameworks/data/test.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import javascript
22
deprecated import utils.test.ConsistencyChecking
33
import semmle.javascript.frameworks.data.internal.ApiGraphModels as ApiGraphModels
44

5+
overlay[local]
56
class TypeModelFromCodeQL extends ModelInput::TypeModel {
67
override predicate isTypeUsed(string type) { type = "danger-constant" }
78

javascript/ql/test/library-tests/frameworks/data/warnings.ql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import javascript
22
import semmle.javascript.frameworks.data.internal.ApiGraphModels as ApiGraphModels
33

4+
overlay[local]
45
class IsTesting extends ApiGraphModels::TestAllModels {
56
IsTesting() { this = this }
67
}

0 commit comments

Comments
 (0)