Tag with quality and sub-category

Author: owen-mc

java/ql/src/Advisory/Declarations/MissingOverrideAnnotation.ql

@@ -6,7 +6,9 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/missing-override-annotation
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import java

java/ql/src/Advisory/Deprecated Code/AvoidDeprecatedCallableAccess.ql

@@ -6,7 +6,9 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/deprecated-call
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  *       non-attributable
  *       external/cwe/cwe-477
  */

java/ql/src/Advisory/Documentation/ImpossibleJavadocThrows.ql

@@ -6,7 +6,9 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/inconsistent-javadoc-throws
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import java

java/ql/src/Advisory/Documentation/SpuriousJavadocParam.ql

@@ -6,7 +6,9 @@
  * @problem.severity recommendation
  * @precision very-high
  * @id java/unknown-javadoc-parameter
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import java

java/ql/src/Compatibility/JDK9/JdkInternalAccess.ql

@@ -6,7 +6,9 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/jdk-internal-api-access
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import java

java/ql/src/Compatibility/JDK9/UnderscoreIdentifier.ql

@@ -6,7 +6,9 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/underscore-identifier
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import java

java/ql/src/DeadCode/UselessParameter.ql

@@ -5,7 +5,8 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/unused-parameter
- * @tags maintainability
+ * @tags quality
+ *       maintainability
  *       useless-code
  *       external/cwe/cwe-561
  */

java/ql/src/Language Abuse/ChainedInstanceof.ql

@@ -5,7 +5,9 @@
  * @problem.severity recommendation
  * @precision high
  * @id java/chained-type-tests
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       complexity
  *       language-features
  */
 

java/ql/src/Language Abuse/IterableIterator.ql

@@ -7,8 +7,9 @@
  * @problem.severity warning
  * @precision very-high
  * @id java/iterator-implements-iterable
- * @tags correctness
+ * @tags quality
  *       reliability
+ *       correctness
  */
 
 import java

java/ql/src/Language Abuse/UselessNullCheck.ql

@@ -6,7 +6,8 @@
  * @problem.severity warning
  * @precision very-high
  * @id java/useless-null-check
- * @tags maintainability
+ * @tags quality
+ *       maintainability
  *       useless-code
  *       external/cwe/cwe-561
  */