Merge pull request #10216 from hvitved/ssa/shared-lib

SSA: Create a new `codeql/shared-ssa` library pack and move implementation there

Author: hvitved

.github/workflows/check-qldoc.yml

@@ -27,7 +27,8 @@ jobs:
         run: |
           EXIT_CODE=0
           # TODO: remove the swift exception from the regex when we fix generated QLdoc
-          changed_lib_packs="$(git diff --name-only --diff-filter=ACMRT HEAD^ HEAD | { grep -Po '^(?!swift)[a-z]*/ql/lib' || true; } | sort -u)"
+          # TODO: remove the shared exception from the regex when coverage of qlpacks without dbschemes is supported
+          changed_lib_packs="$(git diff --name-only --diff-filter=ACMRT HEAD^ HEAD | { grep -Po '^(?!(swift|shared))[a-z]*/ql/lib' || true; } | sort -u)"
           for pack_dir in ${changed_lib_packs}; do
             lang="${pack_dir%/ql/lib}"
             codeql generate library-doc-coverage --output="${RUNNER_TEMP}/${lang}-current.txt" --dir="${pack_dir}"

.github/workflows/ruby-build.yml

@@ -95,6 +95,7 @@ jobs:
         uses: ./.github/actions/fetch-codeql
       - name: Build Query Pack
         run: |
+          codeql pack create ../shared/ssa --output target/packs
           codeql pack create ql/lib --output target/packs
           codeql pack install ql/src
           codeql pack create ql/src --output target/packs

codeql-workspace.yml

@@ -4,6 +4,7 @@ provide:
   - "*/ql/test/qlpack.yml"
   - "*/ql/examples/qlpack.yml"
   - "*/ql/consistency-queries/qlpack.yml"
+  - "shared/*/qlpack.yml"
   - "cpp/ql/test/query-tests/Security/CWE/CWE-190/semmle/tainted/qlpack.yml"
   - "go/ql/config/legacy-support/qlpack.yml"
   - "go/build/codeql-extractor-go/codeql-extractor.yml"

config/identical-files.json

@@ -461,12 +461,6 @@
     "javascript/ql/lib/IDEContextual.qll",
     "python/ql/lib/analysis/IDEContextual.qll"
   ],
-  "SSA C#": [
-    "csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImplCommon.qll",
-    "ruby/ql/lib/codeql/ruby/dataflow/internal/SsaImplCommon.qll",
-    "cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaImplCommon.qll",
-    "swift/ql/lib/codeql/swift/dataflow/internal/SsaImplCommon.qll"
-  ],
   "CryptoAlgorithms Python/JS/Ruby": [
     "javascript/ql/lib/semmle/javascript/security/CryptoAlgorithms.qll",
     "python/ql/lib/semmle/python/concepts/CryptoAlgorithms.qll",

cpp/ql/lib/qlpack.yml

@@ -5,3 +5,5 @@ dbscheme: semmlecode.cpp.dbscheme
 extractor: cpp
 library: true
 upgrades: upgrades
+dependencies:
+  codeql/ssa: 0.0.1

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll

@@ -4,7 +4,7 @@ private import DataFlowUtil
 private import DataFlowImplCommon as DataFlowImplCommon
 private import semmle.code.cpp.models.interfaces.Allocation as Alloc
 private import semmle.code.cpp.models.interfaces.DataFlow as DataFlow
-private import SsaImplCommon as SsaImplCommon
+private import codeql.ssa.Ssa as SsaImplCommon
 
 private module SourceVariables {
   private newtype TSourceVariable =

csharp/ql/lib/qlpack.yml

@@ -5,3 +5,5 @@ dbscheme: semmlecode.csharp.dbscheme
 extractor: csharp
 library: true
 upgrades: upgrades
+dependencies:
+  codeql/ssa: 0.0.1 

csharp/ql/lib/semmle/code/cil/internal/SsaImpl.qll

@@ -1,5 +1,5 @@
 private import cil
-private import semmle.code.csharp.dataflow.internal.SsaImplCommon as SsaImplCommon
+private import codeql.ssa.Ssa as SsaImplCommon
 
 private module SsaInput implements SsaImplCommon::InputSig {
   class BasicBlock = CIL::BasicBlock;

csharp/ql/lib/semmle/code/csharp/controlflow/internal/PreSsa.qll

@@ -9,7 +9,7 @@ module PreSsa {
   private import AssignableDefinitions
   private import semmle.code.csharp.controlflow.internal.ControlFlowGraphImpl
   private import semmle.code.csharp.controlflow.internal.PreBasicBlocks as PreBasicBlocks
-  private import semmle.code.csharp.dataflow.internal.SsaImplCommon as SsaImplCommon
+  private import codeql.ssa.Ssa as SsaImplCommon
 
   private predicate definitionAt(
     AssignableDefinition def, SsaInput::BasicBlock bb, int i, SsaInput::SourceVariable v

csharp/ql/lib/semmle/code/csharp/dataflow/internal/BaseSSA.qll

@@ -5,7 +5,7 @@ import csharp
  */
 module BaseSsa {
   private import AssignableDefinitions
-  private import semmle.code.csharp.dataflow.internal.SsaImplCommon as SsaImplCommon
+  private import codeql.ssa.Ssa as SsaImplCommon
 
   /**
    * Holds if the `i`th node of basic block `bb` is assignable definition `def`,