Shared: improve join order in filterByLocation

jbj · jbj · commit f1e9f0e323cf · 2025-07-09T09:24:26.000+02:00
It's better to join with the range expression first since that will only
multiply tuple counts by the number of lines in an average source/sink.
Joining with `restrictAlertsToStartLine` first would multiply tuple
counts by the number of sources/sinks in a given file.
diff --git a/shared/util/codeql/util/AlertFiltering.qll b/shared/util/codeql/util/AlertFiltering.qll
@@ -98,7 +98,7 @@ module AlertFilteringImpl<LocationSig Location> {
       exists(int locStartLine, int locEndLine |
         location.hasLocationInfo(filePath, locStartLine, _, locEndLine, _)
       |
-        restrictAlertsToStartLine(filePath, [locStartLine .. locEndLine])
+        restrictAlertsToStartLine(pragma[only_bind_into](filePath), [locStartLine .. locEndLine])
       )
     )
     or

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ module AlertFilteringImpl<LocationSig Location> {`
`98`	`98`	`exists(int locStartLine, int locEndLine \|`
`99`	`99`	`location.hasLocationInfo(filePath, locStartLine, _, locEndLine, _)`
`100`	`100`	`\|`
`101`		`- restrictAlertsToStartLine(filePath, [locStartLine .. locEndLine])`
	`101`	`+ restrictAlertsToStartLine(pragma[only_bind_into](filePath), [locStartLine .. locEndLine])`
`102`	`102`	`)`
`103`	`103`	`)`
`104`	`104`	`or`