Add timeouts to the spec tests and integration tests

Author: kpaulisse

.rubocop.yml

@@ -19,7 +19,7 @@ Style/HashSyntax:
 
 # We are setting absurdly high limits but should work to tighten these up.
 Metrics/AbcSize:
-  Max: 100
+  Max: 200
   Severity: warning
 
 Metrics/BlockLength:
@@ -34,7 +34,7 @@ Metrics/CyclomaticComplexity:
   Severity: warning
 
 Metrics/MethodLength:
-  Max: 100
+  Max: 200
   Severity: warning
 
 Metrics/PerceivedComplexity:

spec/octocatalog-diff/integration/integration_helper.rb

@@ -8,6 +8,7 @@
 require 'shellwords'
 require 'stringio'
 require 'tempfile'
+require 'timeout'
 
 module OctocatalogDiff
   class Integration
@@ -124,7 +125,12 @@ def self.integration(options = {})
         $stdout = stdout_strio
 
         # Run the OctocatalogDiff::Cli.cli and validate output format.
-        result = OctocatalogDiff::Cli.cli(argv, logger, options)
+        result = begin
+          timeout(30, Timeout::Error) { OctocatalogDiff::Cli.cli(argv, logger, options) }
+        rescue Timeout::Error => e
+          OpenStruct.new(exitcode: 255, exception: e, diffs: [], to: nil, from: nil)
+        end
+
         if result.is_a?(Integer)
           result = OpenStruct.new(exitcode: result, exception: nil, diffs: [], to: nil, from: nil)
         elsif result.is_a?(Hash)

spec/octocatalog-diff/tests/spec_helper.rb

@@ -3,6 +3,7 @@
 require 'rspec'
 require 'rspec/retry'
 require 'tempfile'
+require 'timeout'
 
 # Enable SimpleCov coverage testing?
 if ENV['COVERAGE']
@@ -31,6 +32,23 @@
   config.display_try_failure_messages = true
 end
 
+# We should not have any individual tests that take more than 10 seconds, so
+# set the timeout here to reap any that get stuck. Hopefully this will prevent
+# jobs from intermittently timing out on travis CI.
+# Inspired by https://github.com/basho/innertube/blob/master/spec/support/timeout.rb
+RSpec.configure do |config|
+  config.around(:each) do |example|
+    time = example.metadata[:timeout] || 10
+    begin
+      timeout(time, Timeout::Error) do
+        example.run
+      end
+    rescue Timeout::Error => e
+      example.send :set_exception, e
+    end
+  end
+end
+
 module OctocatalogDiff
   class Spec
     # Set up a logger that is usable across parent and child forks.