Merge pull request #302 from veeravallib/master

Update resource gitlab_group_label to read labels from all pages

Author: ringods

gitlab/resource_gitlab_group_label.go

@@ -1,8 +1,6 @@
 package gitlab
 
 import (
-	"errors"
-	"fmt"
 	"log"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
@@ -68,24 +66,27 @@ func resourceGitlabGroupLabelRead(d *schema.ResourceData, meta interface{}) erro
 	labelName := d.Id()
 	log.Printf("[DEBUG] read gitlab group label %s/%s", group, labelName)
 
-	labels, _, err := client.GroupLabels.ListGroupLabels(group, nil)
-	if err != nil {
-		return err
-	}
-	found := false
-	for _, label := range labels {
-		if label.Name == labelName {
-			d.Set("description", label.Description)
-			d.Set("color", label.Color)
-			d.Set("name", label.Name)
-			found = true
-			break
+	page := 1
+	labelsLen := 0
+	for page == 1 || labelsLen != 0 {
+		labels, _, err := client.GroupLabels.ListGroupLabels(group, &gitlab.ListGroupLabelsOptions{Page: page})
+		if err != nil {
+			return err
 		}
-	}
-	if !found {
-		return errors.New(fmt.Sprintf("label %s does not exist or the user does not have permissions to see it", labelName))
+		for _, label := range labels {
+			if label.Name == labelName {
+				d.Set("description", label.Description)
+				d.Set("color", label.Color)
+				d.Set("name", label.Name)
+				return nil
+			}
+		}
+		labelsLen = len(labels)
+		page = page + 1
 	}
 
+	log.Printf("[DEBUG] failed to read gitlab label %s/%s", group, labelName)
+	d.SetId("")
 	return nil
 }
 

gitlab/resource_gitlab_group_label_test.go

@@ -52,6 +52,34 @@ func TestAccGitlabGroupLabel_basic(t *testing.T) {
 					}),
 				),
 			},
+			{
+				Config: testAccGitlabGroupLabelLargeConfig(rInt),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.20", &label),
+					testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.30", &label),
+					testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.40", &label),
+					testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.10", &label),
+					testAccCheckGitlabGroupLabelAttributes(&label, &testAccGitlabGroupLabelExpectedAttributes{
+						Name:        "FIXME11",
+						Color:       "#ffcc00",
+						Description: "fix this test",
+					}),
+				),
+			},
+			{
+				Config: testAccGitlabGroupLabelUpdateLargeConfig(rInt),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.20", &label),
+					testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.30", &label),
+					testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.40", &label),
+					testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.10", &label),
+					testAccCheckGitlabGroupLabelAttributes(&label, &testAccGitlabGroupLabelExpectedAttributes{
+						Name:        "FIXME11",
+						Color:       "#ff0000",
+						Description: "red label",
+					}),
+				),
+			},
 		},
 	})
 }
@@ -70,7 +98,7 @@ func testAccCheckGitlabGroupLabelExists(n string, label *gitlab.GroupLabel) reso
 		}
 		conn := testAccProvider.Meta().(*gitlab.Client)
 
-		labels, _, err := conn.GroupLabels.ListGroupLabels(groupName, nil)
+		labels, _, err := conn.GroupLabels.ListGroupLabels(groupName, &gitlab.ListGroupLabelsOptions{PerPage: 1000})
 		if err != nil {
 			return err
 		}
@@ -167,3 +195,41 @@ resource "gitlab_group_label" "fixme" {
 }
 	`, rInt, rInt, rInt)
 }
+
+func testAccGitlabGroupLabelLargeConfig(rInt int) string {
+	return fmt.Sprintf(`
+resource "gitlab_group" "foo" {
+  name             = "foo-%d"
+  path             = "foo-%d"
+  description      = "Terraform acceptance tests"
+  visibility_level = "public"
+}
+
+resource "gitlab_group_label" "fixme" {
+  group = "${gitlab_group.foo.id}"
+  name = format("FIXME%%02d", count.index+1)
+  count = 100
+  color = "#ffcc00"
+  description = "fix this test"
+}
+	`, rInt, rInt)
+}
+
+func testAccGitlabGroupLabelUpdateLargeConfig(rInt int) string {
+	return fmt.Sprintf(`
+resource "gitlab_group" "foo" {
+  name             = "foo-%d"
+  path             = "foo-%d"
+  description      = "Terraform acceptance tests"
+  visibility_level = "public"
+}
+
+resource "gitlab_group_label" "fixme" {
+  group = "${gitlab_group.foo.id}"
+  name = format("FIXME%%02d", count.index+1)
+  count = 99
+  color = "#ff0000"
+  description = "red label"
+}
+	`, rInt, rInt)
+}