actionViewItem - make sure to also set the aira-label on the label element

isidorn · isidorn · commit 2b53bc71d7cd · 2022-08-05T13:43:08.000+02:00
fixes microsoft#155880
diff --git a/src/vs/base/browser/ui/actionbar/actionViewItems.ts b/src/vs/base/browser/ui/actionbar/actionViewItems.ts
@@ -392,6 +392,14 @@ export class ActionViewItem extends BaseActionViewItem {
 		}
 	}
 
+	override updateTooltip(): void {
+		super.updateTooltip();
+		if (this.label) {
+			const title = this.getTooltip() ?? '';
+			this.label.setAttribute('aria-label', title);
+		}
+	}
+
 	override updateChecked(): void {
 		if (this.label) {
 			if (this.getAction().checked) {

Original file line number	Diff line number	Diff line change
`@@ -392,6 +392,14 @@ export class ActionViewItem extends BaseActionViewItem {`
`392`	`392`	`}`
`393`	`393`	`}`
`394`	`394`
	`395`	`+ override updateTooltip(): void {`
	`396`	`+ super.updateTooltip();`
	`397`	`+ if (this.label) {`
	`398`	`+ const title = this.getTooltip() ?? '';`
	`399`	`+ this.label.setAttribute('aria-label', title);`
	`400`	`+ }`
	`401`	`+ }`
	`402`	`+`
`395`	`403`	`override updateChecked(): void {`
`396`	`404`	`if (this.label) {`
`397`	`405`	`if (this.getAction().checked) {`