Skip to content

Commit 33b2e92

Browse files
authored
nullify actionbar and view item context on dispose, remove notebook overview ruler on dispose (microsoft#167817)
fixes microsoft#167813
1 parent a1f2132 commit 33b2e92

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

src/vs/base/browser/ui/actionbar/actionViewItems.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ export class BaseActionViewItem extends Disposable implements IActionViewItem {
253253
this.element.remove();
254254
this.element = undefined;
255255
}
256-
256+
this._context = undefined;
257257
super.dispose();
258258
}
259259
}

src/vs/base/browser/ui/actionbar/actionbar.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -579,6 +579,7 @@ export class ActionBar extends Disposable implements IActionRunner {
579579
}
580580

581581
override dispose(): void {
582+
this._context = undefined;
582583
this.viewItems = dispose(this.viewItems);
583584
this.getContainer().remove();
584585
super.dispose();

src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2929,6 +2929,8 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
29292929
this._baseCellEditorOptions.forEach(v => v.dispose());
29302930
this._baseCellEditorOptions.clear();
29312931

2932+
this._notebookOverviewRulerContainer.remove();
2933+
29322934
super.dispose();
29332935

29342936
// unref

0 commit comments

Comments
 (0)