Don't do telemetry health check when telemetry is off (microsoft#157274)

Author: lramos15

src/vs/platform/telemetry/browser/1dsAppender.ts

@@ -15,11 +15,5 @@ export class OneDataSystemWebAppender extends AbstractOneDataSystemAppender {
 		iKeyOrClientFactory: string | (() => AppInsightsCore), // allow factory function for testing
 	) {
 		super(isInternalTelemetry, eventPrefix, defaultData, iKeyOrClientFactory);
-
-		// If we cannot fetch the endpoint it means it is down and we should not send any telemetry.
-		// This is most likely due to ad blockers
-		fetch(this.endPointUrl, { method: 'POST' }).catch(err => {
-			this._aiCoreOrKey = undefined;
-		});
 	}
 }

src/vs/platform/telemetry/common/1dsAppender.ts

@@ -9,7 +9,7 @@ import { onUnexpectedError } from 'vs/base/common/errors';
 import { mixin } from 'vs/base/common/objects';
 import { ITelemetryAppender, validateTelemetryData } from 'vs/platform/telemetry/common/telemetryUtils';
 
-const endpointUrl = 'https://mobile.events.data.microsoft.com/OneCollector/1.0';
+export const telemetryEndpointUrl = 'https://mobile.events.data.microsoft.com/OneCollector/1.0';
 
 async function getClient(instrumentationKey: string, addInternalFlag?: boolean, xhrOverride?: IXHROverride): Promise<AppInsightsCore> {
 	const oneDs = await import('@microsoft/1ds-core-js');
@@ -19,7 +19,7 @@ async function getClient(instrumentationKey: string, addInternalFlag?: boolean,
 	// Configure the app insights core to send to collector++ and disable logging of debug info
 	const coreConfig: IExtendedConfiguration = {
 		instrumentationKey,
-		endpointUrl,
+		endpointUrl: telemetryEndpointUrl,
 		loggingLevelTelemetry: 0,
 		loggingLevelConsole: 0,
 		disableCookiesUsage: true,
@@ -59,7 +59,7 @@ export abstract class AbstractOneDataSystemAppender implements ITelemetryAppende
 
 	protected _aiCoreOrKey: AppInsightsCore | string | undefined;
 	private _asyncAiCore: Promise<AppInsightsCore> | null;
-	protected readonly endPointUrl = endpointUrl;
+	protected readonly endPointUrl = telemetryEndpointUrl;
 
 	constructor(
 		private readonly _isInternalTelemetry: boolean,

src/vs/workbench/services/telemetry/browser/telemetryService.ts

@@ -11,11 +11,12 @@ import { ILoggerService } from 'vs/platform/log/common/log';
 import { IProductService } from 'vs/platform/product/common/productService';
 import { IStorageService } from 'vs/platform/storage/common/storage';
 import { OneDataSystemWebAppender } from 'vs/platform/telemetry/browser/1dsAppender';
+import { telemetryEndpointUrl } from 'vs/platform/telemetry/common/1dsAppender';
 import { ClassifiedEvent, GDPRClassification, StrictPropertyCheck } from 'vs/platform/telemetry/common/gdprTypings';
 import { ITelemetryData, ITelemetryInfo, ITelemetryService, TelemetryLevel } from 'vs/platform/telemetry/common/telemetry';
 import { TelemetryLogAppender } from 'vs/platform/telemetry/common/telemetryLogAppender';
 import { ITelemetryServiceConfig, TelemetryService as BaseTelemetryService } from 'vs/platform/telemetry/common/telemetryService';
-import { isInternalTelemetry, ITelemetryAppender, NullTelemetryService, supportsTelemetry } from 'vs/platform/telemetry/common/telemetryUtils';
+import { getTelemetryLevel, isInternalTelemetry, ITelemetryAppender, NullTelemetryService, supportsTelemetry } from 'vs/platform/telemetry/common/telemetryUtils';
 import { IBrowserWorkbenchEnvironmentService } from 'vs/workbench/services/environment/browser/environmentService';
 import { IRemoteAgentService } from 'vs/workbench/services/remote/common/remoteAgentService';
 import { resolveWorkbenchCommonProperties } from 'vs/workbench/services/telemetry/browser/workbenchCommonProperties';
@@ -49,8 +50,15 @@ export class TelemetryService extends Disposable implements ITelemetryService {
 				commonProperties: resolveWorkbenchCommonProperties(storageService, productService.commit, productService.version, isInternal, environmentService.remoteAuthority, productService.embedderIdentifier, productService.removeTelemetryMachineId, environmentService.options && environmentService.options.resolveCommonTelemetryProperties),
 				sendErrorTelemetry: this.sendErrorTelemetry,
 			};
-
 			this.impl = this._register(new BaseTelemetryService(config, configurationService, productService));
+
+			if (getTelemetryLevel(configurationService) !== TelemetryLevel.NONE) {
+				// If we cannot fetch the endpoint it means it is down and we should not send any telemetry.
+				// This is most likely due to ad blockers
+				fetch(telemetryEndpointUrl, { method: 'POST' }).catch(err => {
+					this.impl = NullTelemetryService;
+				});
+			}
 		} else {
 			this.impl = NullTelemetryService;
 		}