fix loading cached remote icons (microsoft#164004)

fix loading cached remote icons (microsoft#163961)

Author: sandy081

src/vs/workbench/browser/parts/activitybar/activitybarPart.ts

@@ -964,6 +964,9 @@ export class ActivitybarPart extends Part implements IPaneCompositeSelectorPart
 					cachedViewContainer.name = placeholderViewContainer.name;
 					cachedViewContainer.icon = placeholderViewContainer.themeIcon ? placeholderViewContainer.themeIcon :
 						placeholderViewContainer.iconUrl ? URI.revive(placeholderViewContainer.iconUrl) : undefined;
+					if (URI.isUri(cachedViewContainer.icon) && this.environmentService.remoteAuthority) {
+						cachedViewContainer.icon = undefined; /* Donot cache uri icons with remote connection */
+					}
 					cachedViewContainer.views = placeholderViewContainer.views;
 					cachedViewContainer.isBuiltin = placeholderViewContainer.isBuiltin;
 				}