-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Implement Enterprise SCIM - Set Groups or Users #3858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3858 +/- ##
==========================================
+ Coverage 92.38% 92.40% +0.01%
==========================================
Files 200 200
Lines 14360 14382 +22
==========================================
+ Hits 13267 13289 +22
Misses 894 894
Partials 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @elminster-aom!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank you, @stevehipwell! |
|
@elminster-aom - please - no more operations on this PR. Once I say "Merging", I'm "taking over" the PR. |
Sorry about that, my bad. I'll be more careful next time. |
No problem. I apologize... I was having a bit of a stressful morning and should have just kept quiet. 😞 |
Related with #3813
From REST API endpoints for Enterprise SCIM docs, implements:
Set SCIM information for a provisioned enterprise group, PUT /scim/v2/enterprises/{enterprise}/Groups/{scim_group_id}
Set SCIM information for a provisioned enterprise user, PUT /scim/v2/enterprises/{enterprise}/Users/{scim_user_id}