Fix encoding non-nil pointers by their by using their actual value (#42)

As described in issue #26 if we unwrap the value of the pointer prior to the slice/array logic this should work. It is placed under the omitempty check, since this would be backwards breaking.

Author: Bouwdie

query/encode.go

@@ -151,6 +151,7 @@ func reflectValue(values url.Values, val reflect.Value, scope string) error {
 			continue
 		}
 		name, opts := parseTag(tag)
+
 		if name == "" {
 			if sf.Anonymous && sv.Kind() == reflect.Struct {
 				// save embedded struct for later processing
@@ -169,6 +170,13 @@ func reflectValue(values url.Values, val reflect.Value, scope string) error {
 			continue
 		}
 
+		for sv.Kind() == reflect.Ptr {
+			if sv.IsNil() {
+				break
+			}
+			sv = sv.Elem()
+		}
+
 		if sv.Type().Implements(encoderType) {
 			if !reflect.Indirect(sv).IsValid() {
 				sv = reflect.New(sv.Type().Elem())
@@ -217,13 +225,6 @@ func reflectValue(values url.Values, val reflect.Value, scope string) error {
 			continue
 		}
 
-		for sv.Kind() == reflect.Ptr {
-			if sv.IsNil() {
-				break
-			}
-			sv = sv.Elem()
-		}
-
 		if sv.Type() == timeType {
 			values.Add(name, valueString(sv, opts))
 			continue

query/encode_test.go

@@ -99,6 +99,10 @@ func TestValues_Pointers(t *testing.T) {
 		{struct{ V []*string }{}, url.Values{}},
 		{struct{ V []*string }{[]*string{&str, &str}}, url.Values{"V": {"s", "s"}}},
 
+		// pointer to slice
+		{struct{ V *[]string }{}, url.Values{"V": {""}}},
+		{struct{ V *[]string }{&[]string{"a", "b"}}, url.Values{"V": {"a", "b"}}},
+
 		// pointer values for the input struct itself
 		{(*struct{})(nil), url.Values{}},
 		{&struct{}{}, url.Values{}},