Skip to content

Commit 1634944

Browse files
committed
fix: remove YAGNI method getGQC(), rename GQC to schemaComposer
GQC is legacy name
1 parent 8d460b1 commit 1634944

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

src/composeWithMongooseDiscriminators.js

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -87,14 +87,13 @@ function createDInterface(baseModelTC: DiscriminatorTypeComposer): GraphQLInterf
8787

8888
resolveType: (value: any) => {
8989
const childDName = value[baseModelTC.getDKey()];
90-
const sComposer = baseModelTC.getGQC(); // get schemaComposer
9190

9291
if (childDName) {
93-
return sComposer.getTC(childDName).getType();
92+
return baseModelTC.schemaComposer.getTC(childDName).getType();
9493
}
9594

9695
// as fallback return BaseModelTC
97-
return sComposer.getTC(baseModelTC.getTypeName()).getType();
96+
return baseModelTC.schemaComposer.getTC(baseModelTC.getTypeName()).getType();
9897
},
9998
// hoisting issue solved, get at time :)
10099
fields: () => getBaseTCFieldsWithTypes(baseModelTC),
@@ -108,7 +107,7 @@ export class DiscriminatorTypeComposer extends TypeComposer {
108107

109108
DKeyETC: EnumTypeComposer;
110109

111-
GQC: SchemaComposer<any>;
110+
schemaComposer: SchemaComposer<any>;
112111

113112
opts: Options;
114113

@@ -143,7 +142,7 @@ export class DiscriminatorTypeComposer extends TypeComposer {
143142
this.discriminators = (baseModel: any).discriminators;
144143

145144
this.childTCs = [];
146-
this.GQC =
145+
this.schemaComposer =
147146
opts.customizationOptions && opts.customizationOptions.schemaComposer
148147
? opts.customizationOptions.schemaComposer
149148
: schemaComposer;
@@ -177,10 +176,6 @@ export class DiscriminatorTypeComposer extends TypeComposer {
177176
prepareBaseResolvers(this);
178177
}
179178

180-
getGQC(): SchemaComposer<any> {
181-
return this.GQC;
182-
}
183-
184179
getDKey(): string {
185180
return this.discriminatorKey;
186181
}

0 commit comments

Comments
 (0)