fix update resolvers: use isRequired for input helper

Author: nodkz

src/resolvers/__tests__/updateById-test.js

@@ -55,17 +55,17 @@ describe('updateById() ->', () => {
   describe('Resolver.args', () => {
     it('should have `input` arg', () => {
       const resolver = updateById(UserModel, UserType);
-      expect(resolver.hasArg('input')).to.be.true;
       const argConfig = resolver.getArg('input');
-      expect(argConfig).has.deep.property('type.name', 'UpdateByIdUserInput');
+      expect(argConfig).property('type').instanceof(GraphQLNonNull);
+      expect(argConfig).deep.property('type.ofType.name', 'UpdateByIdUserInput');
     });
 
     it('should have `input._id` required arg', () => {
       const resolver = updateById(UserModel, UserType);
       const argConfig = resolver.getArg('input') || {};
-      expect(argConfig).property('type').instanceof(GraphQLInputObjectType);
-      if (argConfig.type) {
-        const _idFieldType = new InputTypeComposer(argConfig.type).getFieldType('_id');
+      expect(argConfig).deep.property('type.ofType').instanceof(GraphQLInputObjectType);
+      if (argConfig.type && argConfig.type.ofType) {
+        const _idFieldType = new InputTypeComposer(argConfig.type.ofType).getFieldType('_id');
         expect(_idFieldType).instanceof(GraphQLNonNull);
         expect(getNullableType(_idFieldType)).equal(GraphQLMongoID);
       }

src/resolvers/__tests__/updateMany-test.js

@@ -6,7 +6,7 @@ import updateMany from '../updateMany';
 import Resolver from '../../../../graphql-compose/src/resolver/resolver';
 import TypeComposer from '../../../../graphql-compose/src/typeComposer';
 import { convertModelToGraphQL } from '../../fieldsConverter';
-import { GraphQLInt } from 'graphql';
+import { GraphQLInt, GraphQLNonNull } from 'graphql';
 
 const UserType = convertModelToGraphQL(UserModel, 'User');
 
@@ -69,9 +69,9 @@ describe('updateMany() ->', () => {
 
     it('should have `input` arg', () => {
       const resolver = updateMany(UserModel, UserType);
-      expect(resolver.hasArg('input')).to.be.true;
       const argConfig = resolver.getArg('input');
-      expect(argConfig).has.deep.property('type.name', 'UpdateManyUserInput');
+      expect(argConfig).property('type').instanceof(GraphQLNonNull);
+      expect(argConfig).deep.property('type.ofType.name', 'UpdateManyUserInput');
     });
   });
 

src/resolvers/__tests__/updateOne-test.js

@@ -7,6 +7,7 @@ import Resolver from '../../../../graphql-compose/src/resolver/resolver';
 import TypeComposer from '../../../../graphql-compose/src/typeComposer';
 import { convertModelToGraphQL } from '../../fieldsConverter';
 import GraphQLMongoID from '../../types/mongoid';
+import { GraphQLNonNull } from 'graphql/type';
 
 const UserType = convertModelToGraphQL(UserModel, 'User');
 
@@ -62,11 +63,11 @@ describe('updateOne() ->', () => {
       expect(resolver.hasArg('sort')).to.be.true;
     });
 
-    it('should have `input` arg', () => {
+    it('should have required `input` arg', () => {
       const resolver = updateOne(UserModel, UserType);
-      expect(resolver.hasArg('input')).to.be.true;
       const argConfig = resolver.getArg('input');
-      expect(argConfig).has.deep.property('type.name', 'UpdateOneUserInput');
+      expect(argConfig).property('type').instanceof(GraphQLNonNull);
+      expect(argConfig).deep.property('type.ofType.name', 'UpdateOneUserInput');
     });
   });
 

src/resolvers/updateMany.js

@@ -37,6 +37,7 @@ export default function updateMany(
       ...inputHelperArgsGen(gqType, {
         inputTypeName: `UpdateMany${gqType.name}Input`,
         removeFields: ['id', '_id'],
+        isRequired: true,
       }),
       ...filterHelperArgsGen(model, {
         filterTypeName: `Filter${gqType.name}Input`,

src/resolvers/updateOne.js

@@ -45,6 +45,7 @@ export default function updateOne(
       ...inputHelperArgsGen(gqType, {
         inputTypeName: `UpdateOne${gqType.name}Input`,
         removeFields: ['id', '_id'],
+        isRequired: true,
       }),
       ...filterHelperArgsGen(model, {
         filterTypeName: `Filter${gqType.name}Input`,