validation code moved over and updated to meet new naming conventions. test coverage not passing.

Author: twof

src/validation/__tests__/harness.ts

@@ -2,7 +2,8 @@ import { expectJSON } from '../../__testUtils__/expectJSON.js';
 
 import type { Maybe } from '../../jsutils/Maybe.js';
 
-import { parse } from '../../language/parser.js';
+import type { ParseOptions } from '../../language/parser';
+import { parse } from '../../language/parser';
 
 import type { GraphQLSchema } from '../../type/schema.js';
 
@@ -122,17 +123,24 @@ export function expectValidationErrorsWithSchema(
   schema: GraphQLSchema,
   rule: ValidationRule,
   queryStr: string,
+  parseOptions?: ParseOptions,
 ): any {
-  const doc = parse(queryStr);
+  const doc = parse(queryStr, parseOptions);
   const errors = validate(schema, doc, [rule]);
   return expectJSON(errors);
 }
 
 export function expectValidationErrors(
   rule: ValidationRule,
   queryStr: string,
+  parseOptions?: ParseOptions,
 ): any {
-  return expectValidationErrorsWithSchema(testSchema, rule, queryStr);
+  return expectValidationErrorsWithSchema(
+    testSchema,
+    rule,
+    queryStr,
+    parseOptions,
+  );
 }
 
 export function expectSDLValidationErrors(

src/validation/rules/OverlappingFieldsCanBeMergedRule.ts

@@ -29,8 +29,9 @@ import {
   isObjectType,
 } from '../../type/definition.js';
 
-import { sortValueNode } from '../../utilities/sortValueNode.js';
-import { typeFromAST } from '../../utilities/typeFromAST.js';
+import { applyRequiredStatus } from '../../utilities/applyRequiredStatus';
+import { sortValueNode } from '../../utilities/sortValueNode';
+import { typeFromAST } from '../../utilities/typeFromAST';
 
 import type { ValidationContext } from '../ValidationContext.js';
 
@@ -617,17 +618,22 @@ function findConflict(
   const type1 = def1?.type;
   const type2 = def2?.type;
 
-  if (type1 && type2 && doTypesConflict(type1, type2)) {
-    return [
-      [
-        responseName,
-        `they return conflicting types "${inspect(type1)}" and "${inspect(
-          type2,
-        )}"`,
-      ],
-      [node1],
-      [node2],
-    ];
+  if (type1 && type2) {
+    const modifiedType1 = applyRequiredStatus(type1, node1.nullabilityAssertion);
+    const modifiedType2 = applyRequiredStatus(type2, node2.nullabilityAssertion);
+
+    if (doTypesConflict(modifiedType1, modifiedType2)) {
+      return [
+        [
+          responseName,
+          `they return conflicting types "${inspect(
+            modifiedType1,
+          )}" and "${inspect(modifiedType2)}"`,
+        ],
+        [node1],
+        [node2],
+      ];
+    }
   }
 
   // Collect and compare sub-fields. Use the same "visited fragment names" list