Skip to content

Commit bbf54e4

Browse files
committed
Fixed tests
1 parent b3ad5a2 commit bbf54e4

File tree

5 files changed

+244
-265
lines changed

5 files changed

+244
-265
lines changed

Sources/SwiftDocCoverage/DeclProtocol.swift

Lines changed: 8 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public enum AccessLevel: Int {
4949

5050
protocol DeclProtocol: SyntaxProtocol {
5151
var id: String { get }
52-
var modifiers: DeclModifierListSyntax? { get }
52+
var modifiers: DeclModifierListSyntax { get }
5353
}
5454

5555
extension DeclProtocol {
@@ -72,10 +72,6 @@ extension DeclProtocol {
7272
}
7373

7474
var accessLevel: AccessLevel {
75-
guard let modifiers = modifiers else {
76-
return .internal
77-
}
78-
7975
for modifier in modifiers {
8076
let name = modifier.trimmed.description
8177
switch name {
@@ -98,128 +94,86 @@ extension DeclProtocol {
9894
// MARK: -
9995

10096
extension TypeAliasDeclSyntax: DeclProtocol {
101-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
102-
nil
103-
}
104-
10597
var id: String {
10698
name.trimmed.description
10799
}
108100
}
109101

110102
extension AssociatedTypeDeclSyntax: DeclProtocol {
111-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
112-
nil
113-
}
114-
115103
var id: String {
116104
name.trimmed.description
117105
}
118106
}
119107

120108
extension ClassDeclSyntax: DeclProtocol {
121-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
122-
nil
109+
var id: String {
110+
let genericParameter = genericParameterClause?.trimmed.description ?? ""
111+
return "\(name.trimmed)\(genericParameter)"
123112
}
124-
113+
}
114+
115+
extension ActorDeclSyntax: DeclProtocol {
125116
var id: String {
126117
let genericParameter = genericParameterClause?.trimmed.description ?? ""
127118
return "\(name.trimmed)\(genericParameter)"
128119
}
129120
}
130121

131122
extension StructDeclSyntax: DeclProtocol {
132-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
133-
nil
134-
}
135-
136123
var id: String {
137124
let genericParameter = genericParameterClause?.trimmed.description ?? ""
138125
return "\(name.trimmed)\(genericParameter)"
139126
}
140127
}
141128

142129
extension ProtocolDeclSyntax: DeclProtocol {
143-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
144-
nil
145-
}
146-
147130
var id: String {
148131
name.trimmed.description
149132
}
150133
}
151134

152135
extension ExtensionDeclSyntax: DeclProtocol {
153-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
154-
nil
155-
}
156-
157136
var id: String {
158137
extendedType.trimmed.description
159138
}
160139
}
161140

162141
extension FunctionDeclSyntax: DeclProtocol {
163-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
164-
nil
165-
}
166-
167142
var id: String {
168143
let generic = genericParameterClause?.trimmed.description ?? ""
169144
return "\(name.trimmed)\(generic)\(signature.trimmed)"
170145
}
171146
}
172147

173148
extension InitializerDeclSyntax: DeclProtocol {
174-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
175-
nil
176-
}
177-
178149
var id: String {
179150
let optionalMark = optionalMark?.trimmed.description ?? ""
180151
let generic = genericParameterClause?.trimmed.description ?? ""
181-
let parameters = genericParameterClause?.trimmed ?? .none
182-
return "\(initKeyword.trimmed)\(optionalMark)\(generic)\(parameters)"
152+
return "\(initKeyword.trimmed)\(optionalMark)\(generic)\(signature.trimmed)"
183153
}
184154
}
185155

186156
extension SubscriptDeclSyntax: DeclProtocol {
187-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
188-
nil
189-
}
190-
191157
var id: String {
192158
let generic = genericParameterClause?.trimmed.description ?? ""
193159
return "\(subscriptKeyword.trimmed)\(generic)\(parameterClause.trimmed) \(returnClause.trimmed)"
194160
}
195161
}
196162

197163
extension VariableDeclSyntax: DeclProtocol {
198-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
199-
nil
200-
}
201-
202164
var id: String {
203165
bindings.map { $0.pattern.trimmed.description }.joined(separator: ",")
204166
}
205167
}
206168

207169
extension EnumDeclSyntax: DeclProtocol {
208-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
209-
nil
210-
}
211-
212170
var id: String {
213171
let generic = genericParameterClause?.trimmed.description ?? ""
214172
return "\(name.trimmed.description)\(generic)"
215173
}
216174
}
217175

218176
extension EnumCaseDeclSyntax: DeclProtocol {
219-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
220-
nil
221-
}
222-
223177
var id: String {
224178
elements.map {
225179
let name = $0.name.trimmed.description
@@ -229,21 +183,7 @@ extension EnumCaseDeclSyntax: DeclProtocol {
229183
}
230184
}
231185

232-
extension OperatorDeclSyntax: DeclProtocol {
233-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
234-
nil
235-
}
236-
237-
var id: String {
238-
"\(operatorKeyword.trimmed) \(name.trimmed)"
239-
}
240-
}
241-
242186
extension PrecedenceGroupDeclSyntax: DeclProtocol {
243-
var modifiers: SwiftSyntax.DeclModifierListSyntax? {
244-
nil
245-
}
246-
247187
var id: String {
248188
"\(precedencegroupKeyword.trimmed) \(name.trimmed)"
249189
}

Sources/SwiftDocCoverage/Declaration.swift

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,7 @@ class Declaration {
4949
lazy var name: String = {
5050
let name = decl.id.refine()
5151
let parent = context.map { $0.id }.joined(separator: ".")
52-
53-
return parent.isEmpty
54-
? name
55-
: "\(parent).\(name)"
52+
return parent.isEmpty ? name : "\(parent).\(name)"
5653
}()
5754

5855
init(decl: DeclProtocol, context: [DeclProtocol], line: Int, column: Int) {

Sources/SwiftDocCoverage/Source.swift

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,12 @@ fileprivate class Visitor: SyntaxVisitor {
7878
return .visitChildren
7979
}
8080

81+
override func visit(_ node: ActorDeclSyntax) -> SyntaxVisitorContinueKind {
82+
append(decl: node)
83+
context.append(node)
84+
return .visitChildren
85+
}
86+
8187
override func visit(_ node: StructDeclSyntax) -> SyntaxVisitorContinueKind {
8288
append(decl: node)
8389
context.append(node)
@@ -132,11 +138,6 @@ fileprivate class Visitor: SyntaxVisitor {
132138
return .skipChildren
133139
}
134140

135-
override func visit(_ node: OperatorDeclSyntax) -> SyntaxVisitorContinueKind {
136-
append(decl: node)
137-
return .skipChildren
138-
}
139-
140141
override func visit(_ node: PrecedenceGroupDeclSyntax) -> SyntaxVisitorContinueKind {
141142
append(decl: node)
142143
return .skipChildren
@@ -149,6 +150,11 @@ fileprivate class Visitor: SyntaxVisitor {
149150
assert(decl is ClassDeclSyntax)
150151
}
151152

153+
override func visitPost(_ node: ActorDeclSyntax) {
154+
let decl = context.popLast()
155+
assert(decl is ActorDeclSyntax)
156+
}
157+
152158
override func visitPost(_ node: EnumDeclSyntax) {
153159
let decl = context.popLast()
154160
assert(decl is EnumDeclSyntax)

Sources/swift-doc-coverage/main.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,7 @@ struct SwiftDocCoverage: ParsableCommand {
7171
out = try FileOutput(path: path)
7272
}
7373

74-
let coverage = try Coverage(paths: inputs,
75-
minAccessLevel: minimumAccessLevel.accessLevel,
76-
output: out)
74+
let coverage = try Coverage(paths: inputs, minAccessLevel: minimumAccessLevel.accessLevel, output: out)
7775

7876
switch report {
7977
case .statistics:

0 commit comments

Comments
 (0)