Remove pointless TODO message

antonioeatgoat · antonioeatgoat · commit 62544a2d4022 · 2023-05-05T12:29:07.000+02:00
Apparently `getDeclarationName` will never support T_FN.
diff --git a/Inpsyde/Sniffs/CodeQuality/ReturnTypeDeclarationSniff.php b/Inpsyde/Sniffs/CodeQuality/ReturnTypeDeclarationSniff.php
@@ -171,8 +171,8 @@ private function maybeErrors(
         }
 
         $tokenCode = $file->getTokens()[$position]['code'] ?? '';
-        // TODO Remove check on T_FN if getDeclarationName() will support T_FN out of the box
         $name = $tokenCode !== T_FN ? (string)$file->getDeclarationName($position) : '';
+
         if (
             PhpcsHelpers::functionIsMethod($file, $position)
             && (in_array($name, self::METHODS_WHITELIST, true) || strpos($name, '__') === 0)

Original file line number	Diff line number	Diff line change
`@@ -171,8 +171,8 @@ private function maybeErrors(`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`$tokenCode = $file->getTokens()[$position]['code'] ?? '';`
`174`		`- // TODO Remove check on T_FN if getDeclarationName() will support T_FN out of the box`
`175`	`174`	`$name = $tokenCode !== T_FN ? (string)$file->getDeclarationName($position) : '';`
	`175`	`+`
`176`	`176`	`if (`
`177`	`177`	`PhpcsHelpers::functionIsMethod($file, $position)`
`178`	`178`	`&& (in_array($name, self::METHODS_WHITELIST, true) \|\| strpos($name, '__') === 0)`