Commit c4bdca4
Sam Minnee
Fix Sauce Connect usage.
Sauce Connect appears to update the sessionId value but not the webdriver.remote.sessionid value
when proxying requests from the remote selenium instance to the local proxy. The end result is
that, without this patch, php-webdriver can start an initial sesison but guesses the wrong URL
for subsequent requests.
sessionId in the result seems a more canonical place to get the sesion ID than the
webdrive.remote.sessionid key embedded in the value, so this patch amends AbstractWebDriver to
pass that through, using webdriver.remote.sessionid as a fail-over, just in case.
The change to WebDriver.php is a simple matter of pointing to the right variable.1 parent 5ff757c commit c4bdca4
2 files changed
+12
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
144 | 153 | | |
145 | 154 | | |
146 | 155 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
79 | | - | |
| 78 | + | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| |||
0 commit comments