Commit 9407dc4
committed
fix: SchemaManager now reads vector_dimension from CloudConfiguration
Fixes FHIR-AI-Hackathon bug where SchemaManager always returned 384
dimensions instead of reading from environment variables.
Problem:
- SchemaManager used config.get("embedding_model.dimension", 384)
- ConfigurationManager.get() splits on colons, not dots
- "embedding_model.dimension" is treated as single literal key
- Always returned default 384, never read VECTOR_DIMENSION env var
Solution:
- Use cloud_config.vector.vector_dimension instead
- CloudConfiguration correctly reads VECTOR_DIMENSION environment variable
- Supports Feature 058 configuration priority (env > config > defaults)
Testing:
- Verified with VECTOR_DIMENSION=1024: correctly returns 1024
- Without env var: correctly returns default 384
Related: FHIR-AI-Hackathon comprehensive testing of iris-vector-rag 0.5.2
Note: Additional uses of wrong path remain in common/utils.py (deferred)1 parent c3bce1c commit 9407dc4
1 file changed
+11
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
48 | 51 | | |
49 | 52 | | |
50 | 53 | | |
51 | | - | |
52 | | - | |
53 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
54 | 57 | | |
55 | 58 | | |
56 | 59 | | |
| |||
63 | 66 | | |
64 | 67 | | |
65 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
66 | 72 | | |
67 | 73 | | |
68 | 74 | | |
69 | 75 | | |
70 | | - | |
71 | | - | |
72 | | - | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
74 | 79 | | |
75 | 80 | | |
| |||
0 commit comments