Commit d685d09
fix(select): add missing filled type styles (#30763)
Issue number: resolves #
---------
This is based on
#30755 PR to try to
clean up things.
<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->
<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->
## What is the current behavior?
- Select text color was not according design
- Fill solid type was missing the background color
## What is the new behavior?
- Added the expected color to the select text
- Added missing background color variable to the fill solid type
## Does this introduce a breaking change?
- [ ] Yes
- [X] No
<!--
If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->
---------
Co-authored-by: ionitron <hi@ionicframework.com>1 parent 28caeff commit d685d09
File tree
83 files changed
+19
-4
lines changed- core/src/components/select
- test
- color/select.e2e.ts-snapshots
- custom
- select.e2e.ts-snapshots
- fill/select.e2e.ts-snapshots
- highlight/select.e2e.ts-snapshots
- item/select.e2e.ts-snapshots
- label/select.e2e.ts-snapshots
- shape/select.e2e.ts-snapshots
- size/select.e2e.ts-snapshots
- states/select.e2e.ts-snapshots
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
83 files changed
+19
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
41 | 47 | | |
42 | 48 | | |
43 | 49 | | |
| |||
208 | 214 | | |
209 | 215 | | |
210 | 216 | | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
211 | 223 | | |
212 | 224 | | |
213 | 225 | | |
| |||
219 | 231 | | |
220 | 232 | | |
221 | 233 | | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | 234 | | |
227 | 235 | | |
228 | 236 | | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
229 | 243 | | |
230 | 244 | | |
231 | 245 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
| |||
0 commit comments