Apply suggestions from code review

erik-krogh · alexrford · web-flow · commit ee9b01b5e6f4 · 2023-01-18T22:14:46.000+01:00
Co-authored-by: Alex Ford &lt;alexrford@users.noreply.github.com&gt;
diff --git a/ruby/ql/lib/codeql/ruby/security/UnsafeCodeConstructionCustomizations.qll b/ruby/ql/lib/codeql/ruby/security/UnsafeCodeConstructionCustomizations.qll
@@ -97,7 +97,7 @@ module UnsafeCodeConstruction {
   }
 
   /**
-   * A string constructed from a string-concatenation (e.g. `"foo " + sink`),
+   * A component of a string-concatenation (e.g. `"foo " + sink`),
    * where the resulting string ends up being executed as a code.
    */
   class StringConcatAsSink extends Sink {
diff --git a/ruby/ql/lib/codeql/ruby/security/UnsafeShellCommandConstructionCustomizations.qll b/ruby/ql/lib/codeql/ruby/security/UnsafeShellCommandConstructionCustomizations.qll
@@ -82,7 +82,7 @@ module UnsafeShellCommandConstruction {
   }
 
   /**
-   * A string constructed from a string-concatenation (e.g. `"foo " + sink`),
+   * A component of a string-concatenation (e.g. `"foo " + sink`),
    * where the resulting string ends up being executed as a shell command.
    */
   class StringConcatAsSink extends Sink {

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ module UnsafeCodeConstruction {`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`/**`
`100`		- * A string constructed from a string-concatenation (e.g. `"foo " + sink`),
	`100`	+ * A component of a string-concatenation (e.g. `"foo " + sink`),
`101`	`101`	`* where the resulting string ends up being executed as a code.`
`102`	`102`	`*/`
`103`	`103`	`class StringConcatAsSink extends Sink {`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ module UnsafeShellCommandConstruction {`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`/**`
`85`		- * A string constructed from a string-concatenation (e.g. `"foo " + sink`),
	`85`	+ * A component of a string-concatenation (e.g. `"foo " + sink`),
`86`	`86`	`* where the resulting string ends up being executed as a shell command.`
`87`	`87`	`*/`
`88`	`88`	`class StringConcatAsSink extends Sink {`