use github username for my tests link closes #473

Author: maxbeatty

server/web/auth/github.js

@@ -13,13 +13,11 @@ exports.register = function (server, options, next) {
   });
 
   // attach credentials to view context to let people know they are logged in
-  // attach authorGitHub to view context to construct "My Tests" link in footer
   server.ext('onPreResponse', function (request, reply) {
     const response = request.response;
     if (response.variety === 'view') {
       response.source.context = response.source.context || {};
       response.source.context.credentials = request.auth.isAuthenticated ? request.auth.credentials : null;
-      response.source.context.authorGitHub = request.yar.get('authorGitHub');
     }
     return reply.continue();
   });

server/web/edit/index.js

@@ -129,7 +129,6 @@ exports.register = function (server, options, next) {
                 return pagesService.edit(pageWithTests, update, prevPage.maxRev, prevPage.id);
               })
               .then(resultingRevision => {
-                request.yar.set('authorGitHub', pageWithTests.authorGitHub.replace(/[^a-zA-Z0-9-]/, ''));
                 const r = resultingRevision > 1 ? `/${resultingRevision}` : '';
 
                 reply.redirect(`/${request.params.testSlug}${r}`);

server/web/home/index.js

@@ -104,12 +104,12 @@ exports.register = function (server, options, next) {
                     slugError: defaults.errors.slugDupe
                   });
                 } else {
+                  payload.author = request.auth.credentials.username;
                   return pagesService.create(payload)
                     .then(resultPageId => {
                       const own = request.yar.get('own') || {};
                       own[resultPageId] = true;
                       request.yar.set('own', own);
-                      request.yar.set('authorGitHub', payload.authorGitHub.replace(/[^a-zA-Z0-9-]/, ''));
                       reply.redirect('/' + payload.slug);
                     });
                 }

templates/partials/footer.hbs

@@ -16,9 +16,9 @@
             <a href="/">Add</a>
           </li>
 
-          {{#if authorGitHub}}
+          {{#if credentials}}
             <li>
-              <a href="/browse/{{authorGitHub}}">My tests</a>
+              <a href="/browse/{{credentials.username}}">My tests</a>
             </li>
           {{/if}}