chore: refactor subgraph

Author: shotaronowhere

subgraph/src/PolicyRegistry.ts

@@ -1,49 +1,32 @@
 import { PolicyUpdate } from "../generated/PolicyRegistry/PolicyRegistry";
 import { Court } from "../generated/schema";
-import { ipfs, log, json, Bytes } from "@graphprotocol/graph-ts";
+import { ipfs, log, json, Bytes, TypedMap, JSONValue } from "@graphprotocol/graph-ts";
 
 export function handlePolicyUpdate(event: PolicyUpdate): void {
   const courtID = event.params._courtID.toString();
   const court = Court.load(courtID);
   if (court) {
     court.policy = event.params._policy;
     court.name = event.params._courtName;
+    court.save();
 
     let jsonStr = ipfs.cat(event.params._policy);
-    if (!jsonStr) {
-      log.error("Failed to fetch policy #{} SubcourtID: {}", [event.params._policy, event.params._courtID.toString()]);
-      court.save();
-      return;
-    }
-
-    let jsonObjValueAndSuccess = json.try_fromBytes(jsonStr as Bytes);
-    if (!jsonObjValueAndSuccess.isOk) {
-      log.error(`Error getting json object value for policy #{} SubcourtID: {}`, [
-        event.params._policy,
-        event.params._courtID.toString(),
-      ]);
-      court.save();
-      return;
-    }
-
-    let jsonObj = jsonObjValueAndSuccess.value.toObject();
-    if (!jsonObj) {
-      log.error(`Error converting object value for policy #{} SubcourtID: {}`, [
-        event.params._policy,
-        event.params._courtID.toString(),
-      ]);
-      court.save();
-      return;
-    }
+    if (!jsonStr) return;
 
-    const name = jsonObj.get("name");
-    court.name = name ? name.toString() : null;
+    const jsonObjValueAndSuccess = json.try_fromBytes(jsonStr as Bytes);
+    if (!jsonObjValueAndSuccess.isOk) return;
 
-    const description = jsonObj.get("description");
-    court.description = description ? description.toString() : null;
+    const jsonObj = jsonObjValueAndSuccess.value.toObject();
+    if (!jsonObj) return;
 
-    const requiredSkills = jsonObj.get("requiredSkills");
-    court.requiredSkills = requiredSkills ? requiredSkills.toString() : null;
+    court.name = tryGetValue(jsonObj, "name");
+    court.description = tryGetValue(jsonObj, "description");
+    court.requiredSkills = tryGetValue(jsonObj, "requiredSkills");
     court.save();
   }
 }
+
+function tryGetValue(jsonObj: TypedMap<string, JSONValue>, key: string): string | null {
+  const value = jsonObj.get(key);
+  return value ? value.toString() : null;
+}

subgraph/src/entities/Dispute.ts

@@ -2,6 +2,7 @@ import { KlerosCore, DisputeCreation } from "../../generated/KlerosCore/KlerosCo
 import { Court, Dispute, PeriodIndexCounter } from "../../generated/schema";
 import { ZERO, ONE } from "../utils";
 import { BigInt } from "@graphprotocol/graph-ts";
+import { ensurePeriodIndexCounter } from "./PeriodIndexCounter";
 
 export function createDisputeFromEvent(event: DisputeCreation): void {
   const contract = KlerosCore.bind(event.address);
@@ -19,14 +20,10 @@ export function createDisputeFromEvent(event: DisputeCreation): void {
   dispute.overridden = false;
   dispute.lastPeriodChangeTs = event.block.timestamp;
   dispute.lastPeriodChangeBlockNumber = event.block.number;
-  let counter = PeriodIndexCounter.load("evidence");
-  if (!counter) {
-    counter = new PeriodIndexCounter("evidence");
-    counter.counter = BigInt.fromI32(0);
-  }
-  dispute.periodNotificationIndex = counter.counter;
-  counter.counter = counter.counter.plus(ONE);
-  counter.save();
+  const PeriodIndexCounter = ensurePeriodIndexCounter(dispute.period);
+  dispute.periodNotificationIndex = PeriodIndexCounter.counter;
+  PeriodIndexCounter.counter = PeriodIndexCounter.counter.plus(ONE);
+  PeriodIndexCounter.save();
   const court = Court.load(courtID);
   if (!court) return;
   dispute.periodDeadline = event.block.timestamp.plus(court.timesPerPeriod[0]);

subgraph/src/entities/Draw.ts

@@ -1,6 +1,7 @@
 import { Draw as DrawEvent } from "../../generated/KlerosCore/KlerosCore";
 import { Draw, PeriodIndexCounter, User } from "../../generated/schema";
 import { BigInt } from "@graphprotocol/graph-ts";
+import { ensurePeriodIndexCounter } from "./PeriodIndexCounter";
 
 export function createDrawFromEvent(event: DrawEvent): void {
   const disputeID = event.params._disputeID.toString();
@@ -10,18 +11,14 @@ export function createDrawFromEvent(event: DrawEvent): void {
   const drawID = `${disputeID}-${roundIndex.toString()}-${voteID.toString()}`;
   const draw = new Draw(drawID);
   draw.blockNumber = event.block.number;
-  let counter = PeriodIndexCounter.load("draw");
-  if (!counter) {
-    counter = new PeriodIndexCounter("draw");
-    counter.counter = BigInt.fromI32(0);
-  }
   const user = User.load(event.params._address.toHexString());
   if (user) {
     const duplicateNotification = user.disputes.includes(disputeID);
     if (!duplicateNotification) {
-      draw.drawNotificationIndex = counter.counter;
-      counter.counter = counter.counter.plus(BigInt.fromI32(1));
-      counter.save();
+      const periodIndex = ensurePeriodIndexCounter("draw");
+      draw.drawNotificationIndex = periodIndex.counter;
+      periodIndex.counter = periodIndex.counter.plus(BigInt.fromI32(1));
+      periodIndex.save();
     }
   }
   draw.dispute = disputeID;

subgraph/src/entities/PeriodIndexCounter.ts

@@ -0,0 +1,11 @@
+import { PeriodIndexCounter } from "../../generated/schema";
+import { BigInt } from "@graphprotocol/graph-ts";
+
+export function ensurePeriodIndexCounter(id: string): PeriodIndexCounter {
+  let counter = PeriodIndexCounter.load(id);
+  if (!counter) {
+    counter = new PeriodIndexCounter(id);
+    counter.counter = BigInt.fromI32(0);
+  }
+  return counter;
+}