refactor(sdk): make-answer-id-required-in-schema

Author: tractorss

kleros-sdk/src/dataMappings/utils/disputeDetailsSchema.ts

@@ -33,15 +33,19 @@ export enum QuestionType {
 export const QuestionTypeSchema = z.nativeEnum(QuestionType);
 
 export const AnswerSchema = z.object({
-  id: z
-    .string()
-    .regex(/^0x[0-9a-fA-F]+$/)
-    .optional(),
+  id: z.string().regex(/^0x[0-9a-fA-F]+$/),
   title: z.string(),
   description: z.string(),
   reserved: z.boolean().optional(),
 });
 
+export const RefuseToArbitrateAnswer = {
+  id: "0x0",
+  title: "Refuse to Arbitrate / Invalid",
+  description: "Refuse to Arbitrate / Invalid",
+  reserved: true,
+};
+
 export const AttachmentSchema = z.object({
   label: z.string(),
   uri: z.string(),

kleros-sdk/src/dataMappings/utils/populateTemplate.ts

@@ -1,6 +1,6 @@
 import mustache from "mustache";
 import { DisputeDetails } from "./disputeDetailsTypes";
-import DisputeDetailsSchema from "./disputeDetailsSchema";
+import DisputeDetailsSchema, { RefuseToArbitrateAnswer } from "./disputeDetailsSchema";
 
 export const populateTemplate = (mustacheTemplate: string, data: any): DisputeDetails => {
   const render = mustache.render(mustacheTemplate, data);
@@ -11,5 +11,11 @@ export const populateTemplate = (mustacheTemplate: string, data: any): DisputeDe
     throw validation.error;
   }
 
+  // Filter out any existing answer with id 0 and add our standard Refuse to Arbitrate option
+  (dispute as DisputeDetails).answers = [
+    RefuseToArbitrateAnswer,
+    ...((dispute as DisputeDetails).answers.filter((answer) => answer.id && Number(answer.id) !== 0) || []),
+  ];
+
   return dispute;
 };

kleros-sdk/src/utils/getDispute.ts

@@ -56,16 +56,5 @@ export const getDispute = async (disputeParameters: GetDisputeParameters): Promi
 
   const populatedTemplate = populateTemplate(templateData, data);
 
-  // Filter out any existing answer with id 0 and add our standard Refuse to Arbitrate option
-  populatedTemplate.answers = [
-    {
-      id: "0x0",
-      title: "Refuse to Arbitrate / Invalid",
-      description: "Refuse to Arbitrate / Invalid",
-      reserved: true,
-    },
-    ...(populatedTemplate.answers?.filter((answer) => answer.id && Number(answer.id) !== 0) || []),
-  ];
-
   return populatedTemplate;
 };