Skip to content

Commit a324207

Browse files
committed
rfac: rmoved TestServerAccesslogHandler
Signed-off-by: Yash Patel <yp969803@gmail.com>
1 parent 61d565d commit a324207

File tree

1 file changed

+0
-61
lines changed

1 file changed

+0
-61
lines changed

pkg/status/status_server_test.go

Lines changed: 0 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -419,67 +419,6 @@ func TestServer_dumpAdsBpfMap(t *testing.T) {
419419
})
420420
}
421421

422-
func TestServerAccesslogHandler(t *testing.T) {
423-
t.Run("change accesslog config info", func(t *testing.T) {
424-
config := options.BpfConfig{
425-
Mode: constants.DualEngineMode,
426-
BpfFsPath: "/sys/fs/bpf",
427-
Cgroup2Path: "/mnt/kmesh_cgroup2",
428-
}
429-
cleanup, loader := test.InitBpfMap(t, config)
430-
defer cleanup()
431-
432-
server := &Server{
433-
xdsClient: &controller.XdsClient{
434-
WorkloadController: &workload.Controller{
435-
MetricController: &telemetry.MetricController{},
436-
},
437-
},
438-
loader: loader,
439-
}
440-
server.xdsClient.WorkloadController.MetricController.EnableAccesslog.Store(true)
441-
442-
url := fmt.Sprintf("%s?enable=%s", patternMonitoring, "true")
443-
req := httptest.NewRequest(http.MethodPost, url, nil)
444-
w := httptest.NewRecorder()
445-
server.monitoringHandler(w, req)
446-
447-
url = fmt.Sprintf("%s?enable=%s", patternAccesslog, "false")
448-
req = httptest.NewRequest(http.MethodPost, url, nil)
449-
w = httptest.NewRecorder()
450-
server.accesslogHandler(w, req)
451-
452-
assert.Equal(t, server.xdsClient.WorkloadController.GetAccesslogTrigger(), false)
453-
})
454-
455-
t.Run("when monitoring is disable, cannot enable accesslog", func(t *testing.T) {
456-
config := options.BpfConfig{
457-
Mode: constants.DualEngineMode,
458-
BpfFsPath: "/sys/fs/bpf",
459-
Cgroup2Path: "/mnt/kmesh_cgroup2",
460-
}
461-
cleanup, loader := test.InitBpfMap(t, config)
462-
defer cleanup()
463-
464-
server := &Server{
465-
xdsClient: &controller.XdsClient{
466-
WorkloadController: &workload.Controller{
467-
MetricController: &telemetry.MetricController{},
468-
},
469-
},
470-
loader: loader,
471-
}
472-
server.xdsClient.WorkloadController.MetricController.EnableAccesslog.Store(false)
473-
474-
url := fmt.Sprintf("%s?enable=%s", patternAccesslog, "true")
475-
req := httptest.NewRequest(http.MethodPost, url, nil)
476-
w := httptest.NewRecorder()
477-
server.accesslogHandler(w, req)
478-
479-
assert.Equal(t, server.xdsClient.WorkloadController.GetAccesslogTrigger(), false)
480-
})
481-
}
482-
483422
func TestServerMetricHandler(t *testing.T) {
484423
t.Run("change accesslog, workload metrics and connection metric config info", func(t *testing.T) {
485424
config := options.BpfConfig{

0 commit comments

Comments
 (0)