test(frontend): add some tests to auth effects

Author: kucharzyk

src/main/typescript/app/core/store/auth/auth.actions.ts

@@ -62,15 +62,15 @@ export class AuthErrorAction implements Action {
 }
 
 export class ClearAuthErrorAction implements Action {
-  type = ActionTypes.CLEAR_AUTH_STATE;
+  type = ActionTypes.CLEAR_AUTH_ERROR;
 
   constructor() {
   }
 }
 
 
 export class ClearAuthStateAction implements Action {
-  type = ActionTypes.CLEAR_AUTH_ERROR;
+  type = ActionTypes.CLEAR_AUTH_STATE;
 
   constructor() {
   }

src/main/typescript/app/core/store/auth/auth.effects.spec.ts

@@ -1,16 +1,21 @@
-/* tslint:disable:no-unused-variable */
-import {TestBed, inject} from '@angular/core/testing';
 import {Http, BaseRequestOptions, ConnectionBackend, RequestOptions} from '@angular/http';
 import {MockBackend} from '@angular/http/testing';
-import {CoreModule} from '../../core.module';
 import {AuthEffects} from './auth.effects';
+import {EffectsTestingModule, EffectsRunner} from '@ngrx/effects/testing';
+import {LogoutAction, ActionTypes, LoadAndProcessTokenAction, AuthSuccessAction} from './auth.actions';
+import {TestBed, inject} from '@angular/core/testing';
+import {routerActions} from '@ngrx/router-store';
+
 
 describe('Effects: Auth', () => {
 
+  let runner: EffectsRunner = null;
+  let authEffects: AuthEffects = null;
+
   beforeEach(() => {
     TestBed.configureTestingModule({
       imports: [
-        CoreModule
+        EffectsTestingModule
       ],
       providers: [
         BaseRequestOptions,
@@ -27,9 +32,60 @@ describe('Effects: Auth', () => {
     });
   });
 
+  beforeEach(inject([EffectsRunner, AuthEffects], (_runner: EffectsRunner, _authEffects: AuthEffects) => {
+      runner = _runner;
+      authEffects = _authEffects;
+      _authEffects.jwtToken = null;
+    }
+  ));
+
   it('should exist', inject([AuthEffects], (service: AuthEffects) => {
     expect(service).toBeTruthy();
   }));
 
+  it('should return a CLEAR_AUTH_STATE action after logging out', () => {
+    runner.queue(new LogoutAction());
+
+    authEffects.logout$.subscribe(result => {
+      expect(result.type).toEqual(ActionTypes.CLEAR_AUTH_STATE);
+    });
+
+  });
+
+  it('should return a PROCESS_TOKEN action after LoadAndProcessTokenAction when token is set', () => {
+    authEffects.jwtToken = 'NON_EMPTY';
+    runner.queue(new LoadAndProcessTokenAction());
+    authEffects.loadAndProcessToken$.subscribe(result => {
+      expect(result.type).toEqual(ActionTypes.PROCESS_TOKEN);
+    });
+  });
+
+  it('should return a no action after LoadAndProcessTokenAction when token is not set', () => {
+    authEffects.jwtToken = null;
+    runner.queue(new LoadAndProcessTokenAction());
+
+    authEffects.loadAndProcessToken$.subscribe(result => {
+      expect(result).toBeFalsy();
+      expect(result).toBeTruthy();
+    });
+  });
+
+  it('should return actions after auth success', () => {
+    authEffects.jwtToken = null;
+    runner.queue(new AuthSuccessAction('TOKEN'));
+    let eventCount = 0;
+    authEffects.authSuccess$.subscribe(result => {
+      eventCount++;
+      if (eventCount === 1) {
+        expect(result.type).toEqual(routerActions.GO);
+      }
+
+      if (eventCount === 2) {
+        expect(result.type).toEqual(ActionTypes.PROCESS_TOKEN);
+      }
+
+    });
+  });
+
 
 });

src/main/typescript/app/core/store/auth/auth.effects.ts

@@ -71,7 +71,7 @@ export class AuthEffects {
     });
 
   @LocalStorage('token')
-  private jwtToken: string;
+  public jwtToken: string;
 
   constructor(private http: Http, private actions$: Actions) {
   }

src/main/typescript/app/core/store/auth/auth.reducer.ts

@@ -4,8 +4,14 @@ import 'rxjs/add/operator/let';
 import {AuthState, initialState} from './auth.state';
 import {Actions, ActionTypes, ProcessTokenAction, AuthErrorAction} from './auth.actions';
 
-export function  decodeAccessToken(access_token: string) {
-  return JSON.parse(window.atob(access_token.split('.')[1]));
+export function decodeAccessToken(access_token: string) {
+  try {
+    return JSON.parse(window.atob(access_token.split('.')[1]));
+  } catch (e) {
+    console.log(`access token '${access_token}' is not correct`);
+    return null;
+  }
+
 }
 
 export function authReducer(state = initialState, action: Actions): AuthState {
@@ -17,12 +23,12 @@ export function authReducer(state = initialState, action: Actions): AuthState {
     case ActionTypes.PROCESS_TOKEN:
       const processTokenAction: ProcessTokenAction = action as ProcessTokenAction;
       const userData = decodeAccessToken(processTokenAction.payload);
-      return Object.assign({}, initialState, {
-        authenticated: true,
-        tokenExpirationDate: new Date(userData.exp * 1000),
-        userData: userData,
-        jwtToken: processTokenAction.payload
-      });
+      return (!userData) ? state : Object.assign({}, initialState, {
+          authenticated: true,
+          tokenExpirationDate: new Date(userData.exp * 1000),
+          userData: userData,
+          jwtToken: processTokenAction.payload
+        });
 
     case ActionTypes.AUTH_ERROR:
       const authErrorAction: AuthErrorAction = action as AuthErrorAction;