Merge pull request #59 from labthings/deepsource-fix-bc989c9b

Fix dangerous default argument

Author: jtc42

examples/components/pdf_component.py

@@ -40,8 +40,10 @@ def data(self):
         """Return a 1D data trace."""
         return [self.noisy_pdf(x) for x in self.x_range]
 
-    def average_data(self, n: int = 10, optlist: List[int] = [1, 2, 3]):
+    def average_data(self, n: int = 10, optlist: List[int] = None):
         """Average n-sets of data. Emulates a measurement that may take a while."""
+        if optlist is None:
+            optlist = [1, 2, 3]
         summed_data = self.data
 
         for i in range(n):

labthings/server/labthing.py

@@ -36,10 +36,12 @@ def __init__(
         prefix: str = "",
         title: str = "",
         description: str = "",
-        types: list = [],
+        types: list = None,
         version: str = "0.0.0",
         format_flask_exceptions: bool = True,
     ):
+        if types is None:
+            types = []
         self.app = app  # Becomes a Flask app
         self.sockets = None  # Becomes a Socket(app) websocket handler
 

labthings/server/quick.py

@@ -10,7 +10,7 @@ def create_app(
     prefix: str = "",
     title: str = "",
     description: str = "",
-    types: list = [],
+    types: list = None,
     version: str = "0.0.0",
     handle_errors: bool = True,
     handle_cors: bool = True,
@@ -33,6 +33,8 @@ def create_app(
     Returns:
         (Flask app object, LabThings object)
     """
+    if types is None:
+        types = []
     # Handle arguments
     if flask_kwargs is None:
         flask_kwargs = {}

tests/test_server_quick.py

@@ -12,7 +12,10 @@ def test_create_app():
 
 def test_create_app_options():
     app, labthing = quick.create_app(
-        __name__, flask_kwargs={"static_url_path": "/static"}, handle_cors=False
+        __name__,
+        types=["org.labthings.tests.labthing"],
+        flask_kwargs={"static_url_path": "/static"},
+        handle_cors=False,
     )
     assert isinstance(app, Flask)
     assert isinstance(labthing, LabThing)

tests/test_server_types.py

@@ -86,8 +86,10 @@ def test_function_signature_to_schema():
     from marshmallow import Schema
 
     def test_func(
-        positional: int, n: int = 10, optlist: List[int] = [1, 2, 3], untyped="untyped"
+        positional: int, n: int = 10, optlist: List[int] = None, untyped="untyped"
     ):
+        if optlist is None:
+            optlist = [1, 2, 3]
         pass
 
     gen_schema_dict = types.function_signature_to_schema(test_func)