Merge pull request #479 from libgit2/nullabilly

Give extern'd string known nullability.

Author: Ben Chatelain

ObjectiveGit/GTDiff.h

@@ -14,6 +14,8 @@
 @class GTRepository;
 @class GTTree;
 
+NS_ASSUME_NONNULL_BEGIN
+
 /// An `NSNumber` wrapped `GTDiffOptionsFlags` representing any flags you wish to
 /// pass into the initialisation.
 extern NSString *const GTDiffOptionsFlagsKey;
@@ -172,8 +174,6 @@ typedef NS_OPTIONS(NSInteger, GTDiffFindOptionsFlags) {
 	GTDiffFindOptionsFlagsBreakRewritesForRenamesOnly = GIT_DIFF_BREAK_REWRITES_FOR_RENAMES_ONLY,
 };
 
-NS_ASSUME_NONNULL_BEGIN
-
 /// A class representing a single "diff".
 ///
 /// Analagous to `git_diff_list` in libgit2, this object represents a list of

ObjectiveGit/GTFilter.h

@@ -11,14 +11,14 @@
 @class GTRepository;
 @class GTFilterSource;
 
+NS_ASSUME_NONNULL_BEGIN
+
 /// The error domain for errors originating from GTFilter.
 extern NSString * const GTFilterErrorDomain;
 
 /// A filter with that name has already been registered.
 extern const NSInteger GTFilterErrorNameAlreadyRegistered;
 
-NS_ASSUME_NONNULL_BEGIN
-
 /// Git filter abstraction.
 ///
 /// **Note**: GTFilter is *not* thread safe. Registration and unregistration

ObjectiveGit/GTRemote.h

@@ -14,6 +14,8 @@
 @class GTReference;
 @class GTCredentialProvider;
 
+NS_ASSUME_NONNULL_BEGIN
+
 extern NSString * const GTRemoteRenameProblematicRefSpecs;
 
 // Auto Tag settings. See `git_remote_autotag_option_t`.
@@ -23,8 +25,6 @@ typedef enum {
 	GTRemoteDownloadTagsAll = GIT_REMOTE_DOWNLOAD_TAGS_ALL,
 } GTRemoteAutoTagOption;
 
-NS_ASSUME_NONNULL_BEGIN
-
 /// A class representing a remote for a git repository.
 ///
 /// Analogous to `git_remote` in libgit2.

ObjectiveGit/GTRepository+RemoteOperations.h

@@ -10,11 +10,11 @@
 
 @class GTFetchHeadEntry;
 
+NS_ASSUME_NONNULL_BEGIN
+
 /// A `GTCredentialProvider`, that will be used to authenticate against the remote.
 extern NSString *const GTRepositoryRemoteOptionsCredentialProvider;
 
-NS_ASSUME_NONNULL_BEGIN
-
 @interface GTRepository (RemoteOperations)
 
 #pragma mark - Fetch

ObjectiveGit/GTRepository+Status.h

@@ -12,6 +12,8 @@
 
 @class GTStatusDelta;
 
+NS_ASSUME_NONNULL_BEGIN
+
 /// An enum representing the status of a file
 /// See git_status_t
 typedef NS_OPTIONS(NSInteger, GTFileStatusFlags) {
@@ -81,8 +83,6 @@ typedef enum {
 /// Defaults to including all files.
 extern NSString *const GTRepositoryStatusOptionsPathSpecArrayKey;
 
-NS_ASSUME_NONNULL_BEGIN
-
 @interface GTRepository (Status)
 
 /// `YES` if the working directory has no modified, new, or deleted files.

ObjectiveGit/GTRepository.h

@@ -52,6 +52,8 @@
 @class GTTree;
 @class GTRemote;
 
+NS_ASSUME_NONNULL_BEGIN
+
 /// Checkout strategies used by the various -checkout... methods
 /// See git_checkout_strategy_t
 typedef NS_OPTIONS(NSInteger, GTCheckoutStrategyType) {
@@ -148,8 +150,6 @@ extern NSString * const GTRepositoryInitOptionsInitialHEAD;
 /// initialization.
 extern NSString * const GTRepositoryInitOptionsOriginURLString;
 
-NS_ASSUME_NONNULL_BEGIN
-
 @interface GTRepository : NSObject
 
 /// The file URL for the repository's working directory.