Improving zip strides error message

jmh530 · 9il · commit 2be6a33da125 · 2017-07-20T14:43:44.000+07:00
The way the strides error message work is that two slices could have the same strides when packed and it could trigger. Just making the error message more clear that the slices need to have the same strides when unpacked.
diff --git a/source/mir/ndslice/topology.d b/source/mir/ndslice/topology.d
@@ -2481,7 +2481,7 @@ auto zip
         static assert(isSlice!S == packs, "zip: all Slices must have the same shape packs");
         assert(slices[i + 1]._lengths == slices[0]._lengths, "zip: all slices must have the same lengths");
         static if (sameStrides)
-            assert(slices[i + 1].unpack.strides == slices[0].unpack.strides, "zip: all slices must have the same strides");
+            assert(slices[i + 1].unpack.strides == slices[0].unpack.strides, "zip: all slices must have the same strides when unpacked");
     }
     static if (!sameStrides && minElem(staticMap!(kindOf, Slices)) != Contiguous)
     {

Original file line number	Diff line number	Diff line change
`@@ -2481,7 +2481,7 @@ auto zip`
`2481`	`2481`	`static assert(isSlice!S == packs, "zip: all Slices must have the same shape packs");`
`2482`	`2482`	`assert(slices[i + 1]._lengths == slices[0]._lengths, "zip: all slices must have the same lengths");`
`2483`	`2483`	`static if (sameStrides)`
`2484`		`- assert(slices[i + 1].unpack.strides == slices[0].unpack.strides, "zip: all slices must have the same strides");`
	`2484`	`+ assert(slices[i + 1].unpack.strides == slices[0].unpack.strides, "zip: all slices must have the same strides when unpacked");`
`2485`	`2485`	`}`
`2486`	`2486`	`static if (!sameStrides && minElem(staticMap!(kindOf, Slices)) != Contiguous)`
`2487`	`2487`	`{`