[OpenMP] Fix undefined symbol for Darwin builds #170999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luporl
approved these changes
Dec 8, 2025
Contributor
luporl
left a comment
luporl
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
mjklemm
approved these changes
Dec 8, 2025
Contributor
mjklemm
left a comment
mjklemm
left a comment
There was a problem hiding this comment.
LGTM as a hotfix, but in the long run we might need to find a better way to have target-related magic constants at a single place across libomp and libomptarget.
Contributor
Author
|
Definitively! I wonder why this hadn't been more of a problem before |
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #168554 (comment)