feat: make update filter naming generic (#1413)

bryans99 · web-flow · commit 0fb1b5d9374b · 2023-12-19T09:16:43.000-08:00
diff --git a/packages/extension-sdk/src/connect/tile/tile_sdk.spec.ts b/packages/extension-sdk/src/connect/tile/tile_sdk.spec.ts
@@ -185,7 +185,7 @@ describe('TileSDK', () => {
     tileSdk.updateFilters(filters, true)
     expect(api.send).toBeCalledWith('TILE_UPDATE_FILTERS', {
       filters,
-      runDashboard: true,
+      run: true,
     })
   })
 
diff --git a/packages/extension-sdk/src/connect/tile/tile_sdk.ts b/packages/extension-sdk/src/connect/tile/tile_sdk.ts
@@ -114,11 +114,11 @@ export class TileSDKImpl implements TileSDK {
     }
   }
 
-  updateFilters(filters: Filters, runDashboard = false) {
+  updateFilters(filters: Filters, run = false) {
     if (this.hostApi.isDashboardMountSupported) {
       this.hostApi.send(ExtensionRequestType.TILE_UPDATE_FILTERS, {
         filters,
-        runDashboard,
+        run,
       })
     } else {
       throw NOT_DASHBOARD_MOUNT_NOT_SUPPORTED_ERROR

Original file line number	Diff line number	Diff line change
`@@ -114,11 +114,11 @@ export class TileSDKImpl implements TileSDK {`
`114`	`114`	`}`
`115`	`115`	`}`
`116`	`116`
`117`		`- updateFilters(filters: Filters, runDashboard = false) {`
	`117`	`+ updateFilters(filters: Filters, run = false) {`
`118`	`118`	`if (this.hostApi.isDashboardMountSupported) {`
`119`	`119`	`this.hostApi.send(ExtensionRequestType.TILE_UPDATE_FILTERS, {`
`120`	`120`	`filters,`
`121`		`- runDashboard,`
	`121`	`+ run,`
`122`	`122`	`})`
`123`	`123`	`} else {`
`124`	`124`	`throw NOT_DASHBOARD_MOUNT_NOT_SUPPORTED_ERROR`