Skip to content

Commit fbec58f

Browse files
authored
chore: Add extension-tile-playground package to release-please manifest (#1428)
extension-tile-playground package was not part of the release-please manifest. This meant release-please does not update its package.json with every release PR. For context: Our release PR branch was failing on build. Why? 1. `extension-tile-playground` depends on `extension-sdk`. `extension-sdk` was on 23.20.1. 2. We added a breaking change to it and had to update `extension-tile-playground`. All done in 1 PR. 3. Latest main branch built successfully since since the playground is pointing to `extension-sdk` 23.20.1 which is latest in repo. 4. However release-please created a release PR that bumped `extension-sdk` to 24.0.0, BUT did not bump `extension-tile-playground` package.json's `extension-sdk` dependency which stayed on 23.20.1 5. This forced yarn to pull in `extension-sdk` 23.20.1 from npm which would not contain latest changes in repo, breaking the build. Or so i think!
1 parent 8c42be7 commit fbec58f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.release-please-manifest.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
"packages/wholly-sheet": "0.5.51",
1919
"python": "23.20.1",
2020
"packages/extension-playground": "1.0.12",
21+
"packages/extension-tile-playground": "1.0.0",
2122
"packages/embed-services": "23.20.1",
2223
"packages/embed-components": "23.20.1"
2324
}

packages/extension-tile-playground/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@looker/extension-tile-playground",
3-
"version": "22.10.1",
3+
"version": "1.0.0",
44
"description": "Extension Tile Playground",
55
"main": "lib/index.js",
66
"module": "lib/esm/index.js",

0 commit comments

Comments
 (0)