feat: fallback if renderDepthOffset is not set (#148)

Author: lukasbach

packages/core/src/drag/DraggingPositionEvaluation.ts

@@ -22,7 +22,7 @@ export class DraggingPositionEvaluation {
 
   private offset: 'bottom' | 'top' | undefined;
 
-  private indentation: number;
+  private indentation: number | undefined;
 
   private targetItem: LinearItem;
 
@@ -82,6 +82,10 @@ export class DraggingPositionEvaluation {
    * the x-coordinate of the mouse allows to reparent upwards.
    */
   private maybeReparentUpwards(): DraggingPosition | undefined {
+    if (this.indentation === undefined) {
+      return undefined;
+    }
+
     const treeLinearItems = this.env.linearItems[this.treeId];
     const deepestDepth = treeLinearItems[this.linearIndex].depth;
 

packages/core/src/drag/useDraggingPosition.ts

@@ -80,13 +80,15 @@ export const useDraggingPosition = () => {
       const targetLinearItem = treeLinearItems[linearIndex];
       const targetItem = env.items[targetLinearItem.item];
 
-      const indentation = Math.min(
-        Math.max(
-          Math.floor((e.clientX - treeBb.left) / env.renderDepthOffset),
-          0
-        ),
-        targetLinearItem.depth
-      );
+      const indentation = !env.renderDepthOffset
+        ? undefined
+        : Math.min(
+            Math.max(
+              Math.floor((e.clientX - treeBb.left) / env.renderDepthOffset),
+              0
+            ),
+            targetLinearItem.depth
+          );
 
       let offset: 'top' | 'bottom' | undefined;
 

packages/core/src/types.ts

@@ -523,5 +523,7 @@ export interface LiveDescriptors {
 export type HoveringPosition = {
   linearIndex: number;
   offset: 'bottom' | 'top' | undefined;
-  indentation: number;
+
+  // is undefined if tree renderDepthOffset is not set or zero
+  indentation: number | undefined;
 };