868: Code refactoring

Author: bohdan-harniuk

src/com/magento/idea/magento2plugin/actions/generation/NewCronjobAction.java

@@ -17,8 +17,8 @@
 import com.magento.idea.magento2plugin.actions.generation.dialog.NewCronjobDialog;
 import org.jetbrains.annotations.NotNull;
 
-@SuppressWarnings({"PMD.FieldNamingConventions", "PMD.OnlyOneReturn"})
 public class NewCronjobAction extends AnAction {
+
     public static String ACTION_NAME = "Magento 2 Cron Job";
     public static String ACTION_DESCRIPTION = "Create a new Magento 2 Cron Job";
 
@@ -34,17 +34,16 @@ public void actionPerformed(final @NotNull AnActionEvent event) {
         if (view == null) {
             return;
         }
-
         final Project project = CommonDataKeys.PROJECT.getData(dataContext);
+
         if (project == null) {
             return;
         }
-
         final PsiDirectory directory = view.getOrChooseDirectory();
+
         if (directory == null) {
             return;
         }
-
         NewCronjobDialog.open(project, directory);
     }
 

src/com/magento/idea/magento2plugin/actions/generation/dialog/NewCronjobDialog.java

@@ -26,6 +26,8 @@
 import com.magento.idea.magento2plugin.ui.FilteredComboBox;
 import com.magento.idea.magento2plugin.util.CamelCaseToSnakeCase;
 import com.magento.idea.magento2plugin.util.magento.GetModuleNameByDirectoryUtil;
+import org.jetbrains.annotations.NotNull;
+
 import java.awt.event.ActionEvent;
 import java.awt.event.FocusEvent;
 import java.awt.event.FocusListener;
@@ -117,7 +119,7 @@ public class NewCronjobDialog extends AbstractDialog {
      * @param project Project
      * @param directory Directory
      */
-    public NewCronjobDialog(final Project project, final PsiDirectory directory) {
+    public NewCronjobDialog(final @NotNull Project project, final @NotNull PsiDirectory directory) {
         super();
         this.project = project;
         this.moduleName = GetModuleNameByDirectoryUtil.execute(directory, project);
@@ -246,11 +248,6 @@ public String getCronjobScheduleConfigPath() {
         return this.configPathField.getText().trim();
     }
 
-    @Override
-    protected void onCancel() {
-        dispose();
-    }
-
     private void createUIComponents() {
         final List<String> cronGroups = CronGroupIndex.getInstance(project).getGroups();